diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..72bf984 --- /dev/null +++ b/.gitignore @@ -0,0 +1,24 @@ +### Swift ### +# Xcode +## User settings +xcuserdata/ + +## compatibility with Xcode 8 and earlier (ignoring not required starting Xcode 9) +*.xcscmblueprint +*.xccheckout + +## Obj-C/Swift specific +*.hmap + +## App packaging +*.ipa +*.dSYM.zip +*.dSYM + +## Playgrounds +timeline.xctimeline +playground.xcworkspace + +### SwiftPM ### +Packages +*.xcodeproj \ No newline at end of file diff --git a/AppStoreReviews/Assets.xcassets/AppIcon.appiconset/Contents.json b/App/Resources/Catalogs/Assets.xcassets/AppIcon.appiconset/Contents.json similarity index 100% rename from AppStoreReviews/Assets.xcassets/AppIcon.appiconset/Contents.json rename to App/Resources/Catalogs/Assets.xcassets/AppIcon.appiconset/Contents.json diff --git a/AppStoreReviews/Assets.xcassets/Contents.json b/App/Resources/Catalogs/Assets.xcassets/Contents.json similarity index 100% rename from AppStoreReviews/Assets.xcassets/Contents.json rename to App/Resources/Catalogs/Assets.xcassets/Contents.json diff --git a/AppStoreReviews/Info.plist b/App/Resources/Plists/Info.plist similarity index 92% rename from AppStoreReviews/Info.plist rename to App/Resources/Plists/Info.plist index 5a63475..96f4205 100644 --- a/AppStoreReviews/Info.plist +++ b/App/Resources/Plists/Info.plist @@ -29,15 +29,13 @@ UISupportedInterfaceOrientations UIInterfaceOrientationPortrait - UIInterfaceOrientationLandscapeLeft - UIInterfaceOrientationLandscapeRight UISupportedInterfaceOrientations~ipad - UIInterfaceOrientationPortrait - UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight + UIInterfaceOrientationPortrait + UIInterfaceOrientationPortraitUpsideDown diff --git a/AppStoreReviews/Base.lproj/LaunchScreen.storyboard b/App/Resources/Storyboards/Base.lproj/LaunchScreen.storyboard similarity index 100% rename from AppStoreReviews/Base.lproj/LaunchScreen.storyboard rename to App/Resources/Storyboards/Base.lproj/LaunchScreen.storyboard diff --git a/AppStoreReviews/AppDelegate.swift b/App/Sources/AppDelegate.swift similarity index 100% rename from AppStoreReviews/AppDelegate.swift rename to App/Sources/AppDelegate.swift diff --git a/AppStoreReviews/DetailsViewController.swift b/App/Sources/DetailsViewController.swift similarity index 100% rename from AppStoreReviews/DetailsViewController.swift rename to App/Sources/DetailsViewController.swift diff --git a/AppStoreReviews/FeedViewController.swift b/App/Sources/FeedViewController.swift similarity index 100% rename from AppStoreReviews/FeedViewController.swift rename to App/Sources/FeedViewController.swift diff --git a/AppStoreReviews/Review.swift b/App/Sources/Review.swift similarity index 100% rename from AppStoreReviews/Review.swift rename to App/Sources/Review.swift diff --git a/AppStoreReviews/ReviewCell.swift b/App/Sources/ReviewCell.swift similarity index 100% rename from AppStoreReviews/ReviewCell.swift rename to App/Sources/ReviewCell.swift diff --git a/AppStoreReviews.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist b/AppStoreReviews.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist deleted file mode 100644 index 18d9810..0000000 --- a/AppStoreReviews.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist +++ /dev/null @@ -1,8 +0,0 @@ - - - - - IDEDidComputeMac32BitWarning - - - diff --git a/AppStoreReviews.xcodeproj/project.xcworkspace/xcuserdata/un39nv.xcuserdatad/UserInterfaceState.xcuserstate b/AppStoreReviews.xcodeproj/project.xcworkspace/xcuserdata/un39nv.xcuserdatad/UserInterfaceState.xcuserstate deleted file mode 100644 index cf7e105..0000000 Binary files a/AppStoreReviews.xcodeproj/project.xcworkspace/xcuserdata/un39nv.xcuserdatad/UserInterfaceState.xcuserstate and /dev/null differ diff --git a/AppStoreReviews.xcodeproj/xcuserdata/un39nv.xcuserdatad/xcschemes/xcschememanagement.plist b/AppStoreReviews.xcodeproj/xcuserdata/un39nv.xcuserdatad/xcschemes/xcschememanagement.plist deleted file mode 100644 index 98f21b6..0000000 --- a/AppStoreReviews.xcodeproj/xcuserdata/un39nv.xcuserdatad/xcschemes/xcschememanagement.plist +++ /dev/null @@ -1,14 +0,0 @@ - - - - - SchemeUserState - - AppStoreReviews.xcscheme_^#shared#^_ - - orderHint - 0 - - - - diff --git a/AppStoreReviews.xcodeproj/project.pbxproj b/Reviews.xcodeproj/project.pbxproj similarity index 80% rename from AppStoreReviews.xcodeproj/project.pbxproj rename to Reviews.xcodeproj/project.pbxproj index b8355af..4595627 100644 --- a/AppStoreReviews.xcodeproj/project.pbxproj +++ b/Reviews.xcodeproj/project.pbxproj @@ -3,7 +3,7 @@ archiveVersion = 1; classes = { }; - objectVersion = 50; + objectVersion = 63; objects = { /* Begin PBXBuildFile section */ @@ -17,7 +17,7 @@ /* End PBXBuildFile section */ /* Begin PBXFileReference section */ - 345AD11824C6EDD9004E2EE1 /* AppStoreReviews.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = AppStoreReviews.app; sourceTree = BUILT_PRODUCTS_DIR; }; + 345AD11824C6EDD9004E2EE1 /* Reviews.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Reviews.app; sourceTree = BUILT_PRODUCTS_DIR; }; 345AD11B24C6EDD9004E2EE1 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = ""; }; 345AD12424C6EDDC004E2EE1 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = ""; }; 345AD12724C6EDDC004E2EE1 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = ""; }; @@ -39,23 +39,25 @@ /* End PBXFrameworksBuildPhase section */ /* Begin PBXGroup section */ - 345AD10F24C6EDD9004E2EE1 = { + 02DC7F722BA4F8F0000EEEBE /* Resources */ = { isa = PBXGroup; children = ( - 345AD11A24C6EDD9004E2EE1 /* AppStoreReviews */, - 345AD11924C6EDD9004E2EE1 /* Products */, + 02DC7F762BA4F966000EEEBE /* Catalogs */, + 02DC7F732BA4F92E000EEEBE /* Plists */, + 02DC7F752BA4F952000EEEBE /* Storyboards */, ); + path = Resources; sourceTree = ""; }; - 345AD11924C6EDD9004E2EE1 /* Products */ = { + 02DC7F732BA4F92E000EEEBE /* Plists */ = { isa = PBXGroup; children = ( - 345AD11824C6EDD9004E2EE1 /* AppStoreReviews.app */, + 345AD12924C6EDDC004E2EE1 /* Info.plist */, ); - name = Products; + path = Plists; sourceTree = ""; }; - 345AD11A24C6EDD9004E2EE1 /* AppStoreReviews */ = { + 02DC7F742BA4F93B000EEEBE /* Sources */ = { isa = PBXGroup; children = ( 345AD13224C6EE64004E2EE1 /* DetailsViewController.swift */, @@ -63,19 +65,57 @@ 345AD13124C6EE64004E2EE1 /* Review.swift */, 345AD13024C6EE64004E2EE1 /* ReviewCell.swift */, 345AD11B24C6EDD9004E2EE1 /* AppDelegate.swift */, - 345AD12424C6EDDC004E2EE1 /* Assets.xcassets */, - 345AD12624C6EDDC004E2EE1 /* LaunchScreen.storyboard */, - 345AD12924C6EDDC004E2EE1 /* Info.plist */, ); - path = AppStoreReviews; + path = Sources; + sourceTree = ""; + }; + 02DC7F752BA4F952000EEEBE /* Storyboards */ = { + isa = PBXGroup; + children = ( + 345AD12624C6EDDC004E2EE1 /* LaunchScreen.storyboard */, + ); + path = Storyboards; + sourceTree = ""; + }; + 02DC7F762BA4F966000EEEBE /* Catalogs */ = { + isa = PBXGroup; + children = ( + 345AD12424C6EDDC004E2EE1 /* Assets.xcassets */, + ); + path = Catalogs; + sourceTree = ""; + }; + 345AD10F24C6EDD9004E2EE1 = { + isa = PBXGroup; + children = ( + 345AD11A24C6EDD9004E2EE1 /* App */, + 345AD11924C6EDD9004E2EE1 /* Products */, + ); + sourceTree = ""; + }; + 345AD11924C6EDD9004E2EE1 /* Products */ = { + isa = PBXGroup; + children = ( + 345AD11824C6EDD9004E2EE1 /* Reviews.app */, + ); + name = Products; + sourceTree = ""; + }; + 345AD11A24C6EDD9004E2EE1 /* App */ = { + isa = PBXGroup; + children = ( + 02DC7F742BA4F93B000EEEBE /* Sources */, + 02DC7F722BA4F8F0000EEEBE /* Resources */, + ); + path = App; sourceTree = ""; }; /* End PBXGroup section */ /* Begin PBXNativeTarget section */ - 345AD11724C6EDD9004E2EE1 /* AppStoreReviews */ = { + 345AD11724C6EDD9004E2EE1 /* App */ = { isa = PBXNativeTarget; - buildConfigurationList = 345AD12C24C6EDDC004E2EE1 /* Build configuration list for PBXNativeTarget "AppStoreReviews" */; + buildConfigurationList = 345AD12C24C6EDDC004E2EE1 /* Build configuration list for PBXNativeTarget "App" */; buildPhases = ( 345AD11424C6EDD9004E2EE1 /* Sources */, 345AD11524C6EDD9004E2EE1 /* Frameworks */, @@ -85,9 +125,9 @@ ); dependencies = ( ); - name = AppStoreReviews; + name = App; productName = AppStoreReviews; - productReference = 345AD11824C6EDD9004E2EE1 /* AppStoreReviews.app */; + productReference = 345AD11824C6EDD9004E2EE1 /* Reviews.app */; productType = "com.apple.product-type.application"; }; /* End PBXNativeTarget section */ @@ -98,15 +138,15 @@ attributes = { LastSwiftUpdateCheck = 1160; LastUpgradeCheck = 1160; - ORGANIZATIONNAME = ING; + ORGANIZATIONNAME = "Röck+Cöde"; TargetAttributes = { 345AD11724C6EDD9004E2EE1 = { CreatedOnToolsVersion = 11.6; }; }; }; - buildConfigurationList = 345AD11324C6EDD9004E2EE1 /* Build configuration list for PBXProject "AppStoreReviews" */; - compatibilityVersion = "Xcode 9.3"; + buildConfigurationList = 345AD11324C6EDD9004E2EE1 /* Build configuration list for PBXProject "Reviews" */; + compatibilityVersion = "Xcode 15.3"; developmentRegion = en; hasScannedForEncodings = 0; knownRegions = ( @@ -118,7 +158,7 @@ projectDirPath = ""; projectRoot = ""; targets = ( - 345AD11724C6EDD9004E2EE1 /* AppStoreReviews */, + 345AD11724C6EDD9004E2EE1 /* App */, ); }; /* End PBXProject section */ @@ -281,15 +321,26 @@ buildSettings = { ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; CODE_SIGN_STYLE = Automatic; - INFOPLIST_FILE = AppStoreReviews/Info.plist; + CURRENT_PROJECT_VERSION = 1; + DEVELOPMENT_TEAM = 7FMNM89WKG; + ENABLE_PREVIEWS = YES; + INFOPLIST_FILE = App/Resources/Plists/Info.plist; + INFOPLIST_KEY_CFBundleDisplayName = Reviews; + INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.utilities"; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = com.ing.AppStoreReviews; - PRODUCT_NAME = "$(TARGET_NAME)"; + MARKETING_VERSION = 1.0.0; + PRODUCT_BUNDLE_IDENTIFIER = "com.rock-n-code.assignment.ing.app.reviews"; + PRODUCT_NAME = Reviews; + SUPPORTED_PLATFORMS = "iphoneos iphonesimulator"; + SUPPORTS_MACCATALYST = NO; + SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO; + SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO; SWIFT_VERSION = 5.0; - TARGETED_DEVICE_FAMILY = "1,2"; + TARGETED_DEVICE_FAMILY = 1; }; name = Debug; }; @@ -298,22 +349,33 @@ buildSettings = { ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; CODE_SIGN_STYLE = Automatic; - INFOPLIST_FILE = AppStoreReviews/Info.plist; + CURRENT_PROJECT_VERSION = 1; + DEVELOPMENT_TEAM = 7FMNM89WKG; + ENABLE_PREVIEWS = YES; + INFOPLIST_FILE = App/Resources/Plists/Info.plist; + INFOPLIST_KEY_CFBundleDisplayName = Reviews; + INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.utilities"; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = com.ing.AppStoreReviews; - PRODUCT_NAME = "$(TARGET_NAME)"; + MARKETING_VERSION = 1.0.0; + PRODUCT_BUNDLE_IDENTIFIER = "com.rock-n-code.assignment.ing.app.reviews"; + PRODUCT_NAME = Reviews; + SUPPORTED_PLATFORMS = "iphoneos iphonesimulator"; + SUPPORTS_MACCATALYST = NO; + SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO; + SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO; SWIFT_VERSION = 5.0; - TARGETED_DEVICE_FAMILY = "1,2"; + TARGETED_DEVICE_FAMILY = 1; }; name = Release; }; /* End XCBuildConfiguration section */ /* Begin XCConfigurationList section */ - 345AD11324C6EDD9004E2EE1 /* Build configuration list for PBXProject "AppStoreReviews" */ = { + 345AD11324C6EDD9004E2EE1 /* Build configuration list for PBXProject "Reviews" */ = { isa = XCConfigurationList; buildConfigurations = ( 345AD12A24C6EDDC004E2EE1 /* Debug */, @@ -322,7 +384,7 @@ defaultConfigurationIsVisible = 0; defaultConfigurationName = Release; }; - 345AD12C24C6EDDC004E2EE1 /* Build configuration list for PBXNativeTarget "AppStoreReviews" */ = { + 345AD12C24C6EDDC004E2EE1 /* Build configuration list for PBXNativeTarget "App" */ = { isa = XCConfigurationList; buildConfigurations = ( 345AD12D24C6EDDC004E2EE1 /* Debug */, diff --git a/AppStoreReviews.xcodeproj/project.xcworkspace/contents.xcworkspacedata b/Reviews.xcodeproj/project.xcworkspace/contents.xcworkspacedata similarity index 100% rename from AppStoreReviews.xcodeproj/project.xcworkspace/contents.xcworkspacedata rename to Reviews.xcodeproj/project.xcworkspace/contents.xcworkspacedata