rock-n-code/app-reviews
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

[Framework] Feed List improvements #19

Merged
javier merged 8 commits from framework/feed/view-model-tests into main 2024-03-22 14:44:52 +00:00
Conversation 0 Commits 8 Files Changed 6 +40 -42
2 changed files with 40 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8eec6f5666 - Show all commits

4
Frameworks/Feed/Bundle/Sources/Logic/View Models/FeedListViewModel.swift
View File

@ -61,8 +61,7 @@ extension FeedListViewController {
} }
// MARK: Functions // MARK: Functions
func fetch() { func fetch() async {
Task {
isFilterEnabled = false isFilterEnabled = false
isLoading = items.isEmpty isLoading = items.isEmpty
@ -104,7 +103,6 @@ extension FeedListViewController {
isLoading = false isLoading = false
} }
}
func filter(by option: FilterOption) { func filter(by option: FilterOption) {
guard option != filter else { return } guard option != filter else { return }

6
Frameworks/Feed/Bundle/Sources/UI/View Controllers/FeedListViewController.swift
View File

@ -118,7 +118,7 @@ final class FeedListViewController: UIViewController {
registerTableCells() registerTableCells()
bindViewModel() bindViewModel()
viewModel.fetch() Task { await viewModel.fetch() }
} }
} }
@ -170,7 +170,7 @@ private extension FeedListViewController {
// MARK: Actions // MARK: Actions
@objc func refresh(_ sender: AnyObject) { @objc func refresh(_ sender: AnyObject) {
self.viewModel.fetch() Task { await self.viewModel.fetch() }
} }
// MARK: Functions // MARK: Functions
@ -264,7 +264,7 @@ private extension FeedListViewController {
) )
: nil, : nil,
action: isErrorState action: isErrorState
? { self.viewModel.fetch() } ? { Task { await self.viewModel.fetch() } }
: nil : nil
) )