From b35f294082b7a0cbdf683c873c2d39a193827747 Mon Sep 17 00:00:00 2001 From: Javier Cicchelli Date: Mon, 18 Mar 2024 03:03:48 +0100 Subject: [PATCH 1/4] Created the Filter library in the Libraries package. --- Libraries/Package.swift | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Libraries/Package.swift b/Libraries/Package.swift index 25f97f7..dcc0630 100644 --- a/Libraries/Package.swift +++ b/Libraries/Package.swift @@ -12,6 +12,7 @@ let package = Package( name: .Product.name.kit, targets: [ .Target.feed.kit, + .Target.filter.kit, .Target.foundation.kit, .Target.iTunes.kit, ] @@ -25,6 +26,13 @@ let package = Package( ], path: "Feed/Kit" ), + .target( + name: .Target.filter.kit, + dependencies: [ + .byName(name: .Target.foundation.kit), + ], + path: "Filter/Kit" + ), .target( name: .Target.foundation.kit, path: "Foundation/Kit" @@ -44,6 +52,13 @@ let package = Package( ], path: "Feed/Test" ), + .testTarget( + name: .Target.filter.test, + dependencies: [ + .byName(name: .Target.filter.kit), + ], + path: "Filter/Test" + ), .testTarget( name: .Target.foundation.test, dependencies: [ @@ -73,6 +88,7 @@ private extension String { enum Target { static let feed = "\(String.Product.name)Feed" + static let filter = "\(String.Product.name)Filter" static let foundation = "\(String.Product.name)Foundation" static let iTunes = "\(String.Product.name)iTunes" } -- 2.47.1 From 1aad4dd363e808686e44a9148c7ff53def8899b4 Mon Sep 17 00:00:00 2001 From: Javier Cicchelli Date: Mon, 18 Mar 2024 03:04:21 +0100 Subject: [PATCH 2/4] Moved the FilterWordsUseCase use case from the Foundation library to the Filter library. --- .../Kit/Sources/Use Cases/FilterWordsUseCase.swift | 0 .../Test/Tests/Use Cases/FilterWordsUseCaseTests.swift | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename Libraries/{Foundation => Filter}/Kit/Sources/Use Cases/FilterWordsUseCase.swift (100%) rename Libraries/{Foundation => Filter}/Test/Tests/Use Cases/FilterWordsUseCaseTests.swift (100%) diff --git a/Libraries/Foundation/Kit/Sources/Use Cases/FilterWordsUseCase.swift b/Libraries/Filter/Kit/Sources/Use Cases/FilterWordsUseCase.swift similarity index 100% rename from Libraries/Foundation/Kit/Sources/Use Cases/FilterWordsUseCase.swift rename to Libraries/Filter/Kit/Sources/Use Cases/FilterWordsUseCase.swift diff --git a/Libraries/Foundation/Test/Tests/Use Cases/FilterWordsUseCaseTests.swift b/Libraries/Filter/Test/Tests/Use Cases/FilterWordsUseCaseTests.swift similarity index 100% rename from Libraries/Foundation/Test/Tests/Use Cases/FilterWordsUseCaseTests.swift rename to Libraries/Filter/Test/Tests/Use Cases/FilterWordsUseCaseTests.swift -- 2.47.1 From 38e671a69ed58115b255061c45735d3c16d3d248 Mon Sep 17 00:00:00 2001 From: Javier Cicchelli Date: Mon, 18 Mar 2024 03:06:24 +0100 Subject: [PATCH 3/4] Added the Filter and iTunes test cases to the Libraries test plan. --- Test Plans/Libraries.xctestplan | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Test Plans/Libraries.xctestplan b/Test Plans/Libraries.xctestplan index 67792eb..e1a56ea 100644 --- a/Test Plans/Libraries.xctestplan +++ b/Test Plans/Libraries.xctestplan @@ -18,6 +18,20 @@ "identifier" : "ReviewsFoundationTest", "name" : "ReviewsFoundationTest" } + }, + { + "target" : { + "containerPath" : "container:", + "identifier" : "ReviewsFilterTest", + "name" : "ReviewsFilterTest" + } + }, + { + "target" : { + "containerPath" : "container:", + "identifier" : "ReviewsiTunesTest", + "name" : "ReviewsiTunesTest" + } } ], "version" : 1 -- 2.47.1 From 6be1276be48e658065966a7306e2045c81c394bd Mon Sep 17 00:00:00 2001 From: Javier Cicchelli Date: Mon, 18 Mar 2024 03:20:50 +0100 Subject: [PATCH 4/4] Removed (temporarily) the Libraries test plan from the project. --- .../xcschemes/ReviewsKit.xcscheme | 9 +---- .../Use Cases/FilterWordsUseCaseTests.swift | 3 +- Reviews.xcodeproj/project.pbxproj | 10 ----- Test Plans/Libraries.xctestplan | 38 ------------------- 4 files changed, 4 insertions(+), 56 deletions(-) delete mode 100644 Test Plans/Libraries.xctestplan diff --git a/Libraries/.swiftpm/xcode/xcshareddata/xcschemes/ReviewsKit.xcscheme b/Libraries/.swiftpm/xcode/xcshareddata/xcschemes/ReviewsKit.xcscheme index 6b81aea..d647ee3 100644 --- a/Libraries/.swiftpm/xcode/xcshareddata/xcschemes/ReviewsKit.xcscheme +++ b/Libraries/.swiftpm/xcode/xcshareddata/xcschemes/ReviewsKit.xcscheme @@ -27,13 +27,8 @@ buildConfiguration = "Debug" selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" - shouldUseLaunchSchemeArgsEnv = "YES"> - - - - + shouldUseLaunchSchemeArgsEnv = "YES" + shouldAutocreateTestPlan = "YES">