## Summary Updates the library to v4.5.1 of the App Store Connect API, and ships it as a breaking 2.0.0 release with pagination, API key authentication, rate limiting, and a lighter install for consumers. ## Breaking changes - **Minimum platforms:** iOS 14, macOS 11, tvOS 14, watchOS 7, and visionOS 1. - **Toolchain:** Swift 6.0+ (Xcode 16+). The package builds in the Swift 6 language mode. - **Runtime:** requires `swift-openapi-runtime` 1.11.0 or later. ## Changes - **API:** updated the OpenAPI specification to v4.5.1, covering 1,303 operations and 1,473 schemas. - **Pagination:** the spec patch adds the undocumented `cursor` query parameter to the 465 paged operations. `PagedDocumentLinks.nextCursor` reads the cursor from a page, and `PagedSequence` iterates every page. - **Authentication:** `APIKeyTokenProvider` signs ES256 tokens from an API key and reuses each one until a minute before it expires. `BearerAuthMiddleware` now accepts a token provider. - **Rate limiting:** `RateLimitMiddleware` retries `429` responses, waiting for `Retry-After` or backing off exponentially. - **Generated code:** committed to `Sources/ASConnectService/Sources/Public/Generated` instead of generated by a build plugin. Consumers now resolve 4 packages instead of 12, and Xcode no longer asks to trust a plugin. - **Tooling:** - `make oas-download` now downloads, patches, generates, and checks the docs in one go. - New `make oas-generate`, `make oas-validate`, and `make doc-check` targets. - The generator is pinned in `Tools/`, and the DocC plugin is only resolved by the documentation targets. - **Documentation:** the DocC catalog now lists every operation and schema in the spec, and the catalog and README are rewritten for the new APIs. - **Housekeeping:** Apache 2.0 license headers on every Swift file, including `Package.swift` and the tests. Reviewed-on: #5 Co-authored-by: Javier Cicchelli <javier@rock-n-code.com>
166 lines
5.0 KiB
Swift
166 lines
5.0 KiB
Swift
// ===----------------------------------------------------------------------===
|
|
//
|
|
// This source file is part of the ASConnectService open source project
|
|
//
|
|
// Copyright (c) 2026 Röck+Cöde VoF. and the ASConnectService project authors
|
|
// Licensed under Apache license v2.0
|
|
//
|
|
// See LICENSE for license information
|
|
// See CONTRIBUTORS for the list of ASConnectService project authors
|
|
//
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
//
|
|
// ===----------------------------------------------------------------------===
|
|
|
|
import Foundation
|
|
import HTTPTypes
|
|
import OpenAPIRuntime
|
|
import Testing
|
|
|
|
// A non-testable import ensures that the middleware can be created from outside the module.
|
|
import ASConnectService
|
|
|
|
@Suite("RateLimitMiddleware")
|
|
struct RateLimitMiddlewareTests {
|
|
// MARK: Properties
|
|
|
|
private let recorder = Recorder()
|
|
|
|
// MARK: Tests
|
|
|
|
@Test("Returns a response that is not rate limited without retrying")
|
|
func returnsResponseWithoutRetrying() async throws {
|
|
let response = try await intercept(responses: [.ok])
|
|
|
|
#expect(response.status == .ok)
|
|
#expect(await recorder.calls == 1)
|
|
#expect(await recorder.delays.isEmpty)
|
|
}
|
|
|
|
@Test("Retries rate-limited requests with an exponential backoff")
|
|
func retriesWithBackoff() async throws {
|
|
let response = try await intercept(responses: [.tooManyRequests, .tooManyRequests, .ok])
|
|
|
|
#expect(response.status == .ok)
|
|
#expect(await recorder.calls == 3)
|
|
#expect(await recorder.delays == [1, 2])
|
|
}
|
|
|
|
@Test("Waits for the seconds in the Retry-After header")
|
|
func waitsForRetryAfter() async throws {
|
|
let response = try await intercept(responses: [.tooManyRequests(retryAfter: "5"), .ok])
|
|
|
|
#expect(response.status == .ok)
|
|
#expect(await recorder.delays == [5])
|
|
}
|
|
|
|
@Test("Returns the rate-limited response when the retries run out")
|
|
func returnsResponseWhenRetriesRunOut() async throws {
|
|
let response = try await intercept(
|
|
responses: [.tooManyRequests, .tooManyRequests, .tooManyRequests],
|
|
maximumRetries: 2
|
|
)
|
|
|
|
#expect(response.status == .tooManyRequests)
|
|
#expect(await recorder.calls == 3)
|
|
#expect(await recorder.delays == [1, 2])
|
|
}
|
|
|
|
@Test("Returns the rate-limited response when the delay exceeds the maximum")
|
|
func returnsResponseWhenDelayExceedsMaximum() async throws {
|
|
let response = try await intercept(responses: [.tooManyRequests(retryAfter: "3600"), .ok])
|
|
|
|
#expect(response.status == .tooManyRequests)
|
|
#expect(await recorder.calls == 1)
|
|
#expect(await recorder.delays.isEmpty)
|
|
}
|
|
|
|
@Test("Does not retry a request whose body can only be sent once")
|
|
func doesNotRetrySingleIterationBody() async throws {
|
|
let body = HTTPBody(
|
|
AsyncStream<HTTPBody.ByteChunk> { $0.finish() },
|
|
length: .unknown,
|
|
iterationBehavior: .single
|
|
)
|
|
|
|
let response = try await intercept(responses: [.tooManyRequests, .ok], body: body)
|
|
|
|
#expect(response.status == .tooManyRequests)
|
|
#expect(await recorder.calls == 1)
|
|
}
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private extension RateLimitMiddlewareTests {
|
|
func intercept(
|
|
responses: [HTTPResponse],
|
|
body: HTTPBody? = nil,
|
|
maximumRetries: Int = 3
|
|
) async throws -> HTTPResponse {
|
|
let recorder = recorder
|
|
let middleware = RateLimitMiddleware(
|
|
maximumRetries: maximumRetries,
|
|
baseDelay: 1,
|
|
maximumDelay: 60,
|
|
sleep: { await recorder.record(delay: $0) }
|
|
)
|
|
|
|
let (response, _) = try await middleware.intercept(
|
|
.get,
|
|
body: body,
|
|
baseURL: .base,
|
|
operationID: "apps_getCollection",
|
|
next: { _, _, _ in
|
|
(await recorder.response(from: responses), nil)
|
|
}
|
|
)
|
|
|
|
return response
|
|
}
|
|
}
|
|
|
|
/// An actor that records the calls to the next handler, and the delays the middleware waits for.
|
|
private actor Recorder {
|
|
private(set) var calls = 0
|
|
private(set) var delays: [TimeInterval] = []
|
|
|
|
func response(from responses: [HTTPResponse]) -> HTTPResponse {
|
|
defer { calls += 1 }
|
|
|
|
return responses[calls]
|
|
}
|
|
|
|
func record(delay: TimeInterval) {
|
|
delays.append(delay)
|
|
}
|
|
}
|
|
|
|
// MARK: - HTTPRequest+Samples
|
|
|
|
private extension HTTPRequest {
|
|
static let get = HTTPRequest(
|
|
method: .get,
|
|
scheme: "https",
|
|
authority: "api.appstoreconnect.apple.com",
|
|
path: "/v1/apps"
|
|
)
|
|
}
|
|
|
|
// MARK: - HTTPResponse+Samples
|
|
|
|
private extension HTTPResponse {
|
|
static let ok = HTTPResponse(status: .ok)
|
|
static let tooManyRequests = HTTPResponse(status: .tooManyRequests)
|
|
|
|
static func tooManyRequests(retryAfter: String) -> HTTPResponse {
|
|
HTTPResponse(status: .tooManyRequests, headerFields: [.retryAfter: retryAfter])
|
|
}
|
|
}
|
|
|
|
// MARK: - URL+Samples
|
|
|
|
private extension URL {
|
|
static let base = URL(string: "https://api.appstoreconnect.apple.com")!
|
|
}
|