Fixes for the Localization package (#26)

This PR contains the work done to

Reviewed-on: rock-n-code/loud-amsterdam#26
Co-authored-by: Javier Cicchelli <javier@rock-n-code.com>
Co-committed-by: Javier Cicchelli <javier@rock-n-code.com>

Services/Website/Package.swift

@@ -58,6 +58,7 @@ let package = Package(
         .executableTarget(
             name: "Website",
             dependencies: [
+                .byName(name: "Localization"),
                 .byName(name: "Persistence"),
                 .byName(name: "WebsiteLibrary"),
                 .product(

Services/Website/Sources/App/Extensions/App+Build.swift

@@ -1,6 +1,7 @@
 import Configuration
 import Hummingbird
 import HummingbirdCompression
+import Localization
 import Logging
 import Persistence
 import Infrastructure
@@ -9,7 +10,8 @@ import WebsiteLibrary
 /// Builds the website application.
 ///
 /// Reads the log level, server name, static files location, minimum response size to compress, and security headers from the configuration, then assembles
-/// the router, server configuration, and logger. It also builds the persistence driver, registers its migrations, and attaches the `Fluent` service so it starts
+/// the router, server configuration, and logger. It warns when the localization catalog cannot be read, since pages would serve raw localization keys.
+/// It also builds the persistence driver, registers its migrations, and attaches the `Fluent` service so it starts
 /// and stops alongside the HTTP server; the ephemeral in-memory backend is migrated on startup, while a MySQL/MariaDB backend is migrated out of
 /// band (so a shared database is never migrated on boot).
 /// - Parameter reader: the configuration reader the values are read from.
@@ -17,10 +19,20 @@ import WebsiteLibrary
 func application(
     reader: ConfigReader
 ) async -> some ApplicationProtocol {
+    let languages = LanguageList()
     let logger = logger(
         serverName: reader.serverName,
         logLevel: reader.logLevel
     )
+
+    // A broken catalog degrades to serving raw localization keys rather than failing, so it is
+    // only ever visible to visitors — surface it here instead.
+    if languages.catalogState != .loaded {
+        let isCatalogMissing = languages.catalogState == .missing
+        
+        logger.warning("String Catalog is \(isCatalogMissing ? "missing" : "undecodable"); pages will serve raw localization keys")
+    }
+
     let persistence = Service(
         driver: reader.driver,
         logger: logger

Services/Website/Sources/Library/Internal/Extensions/Page+Defaults.swift

@@ -11,7 +11,7 @@ extension Page {
     /// The document language, derived from the page's locale and falling back to the default language.
     var lang: String {
         locale.language.languageCode?.identifier
-            ?? LanguageList(bundle: .module).default
+            ?? LanguageList().default
     }
 
     /// The icon, manifest, and theme colour metadata shared by every page of the website.

Services/Website/Sources/Library/Public/Extensions/LanguageList+Defaults.swift

@@ -0,0 +1,13 @@
+import Foundation
+import Localization
+
+public extension LanguageList {
+
+    // MARK: Initializers
+
+    /// Creates a language list backed by the module's String Catalog.
+    init() {
+        self.init(bundle: .module)
+    }
+
+}