rock-n-code/my-files-sample
rock-n-code/my-files-sample
1
0
Fork 0
Code Releases Wiki Activity

Added support for the "forbidden" response status in the APIClient client.

Browse Source
This commit is contained in:
Javier Cicchelli 2022-12-04 17:50:15 +01:00
parent 74a22d5844
commit 29e19d8fdf
3 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/Sources/APIService/Enumerations/ResponseStatus.swift
View File

@ -11,5 +11,6 @@ enum ResponseStatus: Int {
case created = 201
case noContent = 204
case badRequest = 400
case forbidden = 403
case notFound = 404
}

5
Libraries/Sources/APIService/Structs/APIClient.swift
View File

@ -50,6 +50,8 @@ extension APIClient: Client {
throw APIClientError.notSupported
case .badRequest:
throw APIClientError.itemAlreadyExist
case .forbidden:
throw APIClientError.authenticationFailed
case .notFound:
throw APIClientError.itemDoesNotExist
}
@ -77,6 +79,8 @@ extension APIClient: Client {
throw APIClientError.notSupported
case .badRequest:
throw APIClientError.itemIsNotFile
case .forbidden:
throw APIClientError.authenticationFailed
case .notFound:
throw APIClientError.itemDoesNotExist
}
@ -106,6 +110,7 @@ private extension APIClient {
public enum APIClientError: Error {
case responseNotReturned
case authenticationFailed
case itemIsNotFile
case itemAlreadyExist
case itemDoesNotExist

51
Libraries/Tests/APIServiceTests/Cases/Structs/APIClient+RequestTests.swift
View File

@ -157,6 +157,31 @@ final class APIClientRequestTests: XCTestCase {
}
}
func test_withSomeEndpoint_andSomeModel_whenResponseStatusForbidden() async throws {
// GIVEN
let endpoint = GetMeEndpoint(
username: "username",
password: "password"
)
url = try makeURLRequest(endpoint: endpoint).url
MockURLProtocol.mockData[url] = MockURLResponse(
status: .forbidden,
headers: [:],
data: nil
)
// WHEN & THEN
do {
_ = try await client.request(endpoint: endpoint, model: Me.self)
} catch APIClientError.authenticationFailed {
XCTAssertTrue(true)
} catch {
XCTAssertTrue(false)
}
}
func test_withSomeEndpoint_andSomeModel_whenResponseStatusNotFound() async throws {
// GIVEN
let endpoint = GetMeEndpoint(
@ -308,6 +333,32 @@ final class APIClientRequestTests: XCTestCase {
}
}
func test_withSomeEndpoint_whenResponseStatusForbidden() async throws {
// GIVEN
let endpoint = GetDataEndpoint(
itemId: UUID().uuidString,
username: "username",
password: "password"
)
url = try makeURLRequest(endpoint: endpoint).url
MockURLProtocol.mockData[url] = MockURLResponse(
status: .forbidden,
headers: [:],
data: nil
)
// WHEN & THEN
do {
try await client.request(endpoint: endpoint)
} catch APIClientError.authenticationFailed {
XCTAssertTrue(true)
} catch {
XCTAssertTrue(false)
}
}
func test_withSomeEndpoint_whenResponseStatusNotFound() async throws {
// GIVEN
let endpoint = GetDataEndpoint(