rock-n-code/amiibo-service
1
0
Fork 0
Code Issues Pull Requests Actions Releases 15 Activity

Possible fix for compilation issue in Swift 5 #11

Merged
javier merged 1 commits from fix/swift-5 into main 2025-09-11 22:49:59 +00:00
Conversation 0 Commits 1 Files Changed 5
+419 -2
javier commented 2025-09-11 22:49:51 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to amend the issue #9 which, basically, provides a separate functions declaration for the APIClient protocol and the AmiiboService service type on Swift 5.

This PR contains the work done to amend the issue #9 which, basically, provides a separate functions declaration for the `APIClient` protocol and the `AmiiboService` service type on Swift 5.
javier added the Kind/Bug
Priority
Critical
 labels 2025-09-11 22:49:51 +00:00
javier self-assigned this 2025-09-11 22:49:51 +00:00
javier added 1 commit 2025-09-11 22:49:52 +00:00
Improved the APIClient protocol in the library target to provide unspecified error for Swift 5. 467bab4434
javier merged commit 19583290be into main 2025-09-11 22:49:59 +00:00
javier deleted branch fix/swift-5 2025-09-11 22:49:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Kind/Bug
Priority
Critical
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Reference: rock-n-code/amiibo-service#11
Delete Branch "fix/swift-5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?