javier
6c1a0f713b
This PR contains the work done to add cache-control headers to static file responses by configuring the `FileMiddleware` middleware to tag served static files with *Cache-Control* directives, tuned per media type. To provide further details about the work done: * Added a cache control that sets per-type policies: text assets (CSS/JS) get public, max-age, must-revalidate; images get public, max-age; everything else gets a default public, max-age. * Files stay validated via `ETag/Last-Modified` header. * Made the max-age values configurable, with defaults, via new cache constants. Reviewed-on: rock-n-code/loud-amsterdam#6 Co-authored-by: Javier Cicchelli <javier@rock-n-code.com> Co-committed-by: Javier Cicchelli <javier@rock-n-code.com>
124 lines
3.4 KiB
Swift
124 lines
3.4 KiB
Swift
import Configuration
|
|
import Foundation
|
|
import Hummingbird
|
|
import HummingbirdTesting
|
|
import Logging
|
|
import NIOCore
|
|
import Testing
|
|
|
|
@testable import Website
|
|
@testable import WebsiteCore
|
|
|
|
@Suite("App executable")
|
|
struct AppTests {
|
|
|
|
// MARK: Constants
|
|
|
|
private let textExtensions: [StaticFile.Extension] = [
|
|
.css,
|
|
.js,
|
|
.txt
|
|
]
|
|
|
|
// Absolute path to the package's "Resources/Static" folder, derived from this
|
|
// file's location so the static files resolve regardless of the working directory.
|
|
private let staticFilesPath = URL(fileURLWithPath: #filePath)
|
|
.deletingLastPathComponent() // Tests/App
|
|
.deletingLastPathComponent() // Tests
|
|
.deletingLastPathComponent() // package root
|
|
.appendingPathComponent(.Path.staticResources)
|
|
.path
|
|
|
|
// MARK: Functional tests
|
|
|
|
@Test
|
|
func `landing page to be served at root`() async throws {
|
|
try await app.test(.router) { client in
|
|
try await client.execute(
|
|
uri: "/",
|
|
method: .get
|
|
) { response in
|
|
let body = String(buffer: response.body)
|
|
|
|
#expect(response.status == .ok)
|
|
#expect(response.headers[.contentType] == "text/html; charset=utf-8")
|
|
#expect(body.contains("Hello world!"))
|
|
}
|
|
}
|
|
}
|
|
|
|
@Test(arguments: StaticFile.allCases)
|
|
func `static files to be served`(
|
|
staticFile file: StaticFile
|
|
) async throws {
|
|
try await app.test(.router) { client in
|
|
try await client.execute(
|
|
uri: "/\(file.relativePath)",
|
|
method: .get
|
|
) { response in
|
|
#expect(response.status == .ok)
|
|
#expect(response.headers[.contentType] == file.contentType)
|
|
|
|
let cacheControl = try #require(response.headers[.cacheControl])
|
|
|
|
#expect(cacheControl.contains("public") == true)
|
|
#expect(cacheControl.contains("max-age=") == true)
|
|
|
|
if textExtensions.contains(file.fileExtension) {
|
|
#expect(cacheControl.contains("must-revalidate") == true)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
@Test
|
|
func `error page to be served when not found`() async throws {
|
|
try await app.test(.router) { client in
|
|
try await client.execute(
|
|
uri: "/this-path-does-not-exist",
|
|
method: .get
|
|
) { response in
|
|
let body = String(buffer: response.body)
|
|
|
|
#expect(response.status == .notFound)
|
|
#expect(response.headers[.contentType] == "text/html; charset=utf-8")
|
|
#expect(body.contains("Page Not Found"))
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private extension AppTests {
|
|
|
|
// MARK: Computed
|
|
|
|
var app: some ApplicationProtocol {
|
|
get async {
|
|
await application(
|
|
reader: reader(
|
|
staticFilesPath: staticFilesPath
|
|
)
|
|
)
|
|
}
|
|
}
|
|
|
|
// MARK: Methods
|
|
|
|
func reader(
|
|
staticFilesPath: String
|
|
) -> ConfigReader {
|
|
ConfigReader(providers: [
|
|
InMemoryProvider(values: [
|
|
.HTTP.host: "127.0.0.1",
|
|
.HTTP.port: "0",
|
|
.Log.level: "trace",
|
|
.Path.staticFiles: .init(stringLiteral: staticFilesPath),
|
|
])
|
|
])
|
|
}
|
|
|
|
}
|