[Feature] Enhance the places deep linking support in the Wikipedia app to support coordinates #2

Merged

javier merged 5 commits from feature/places-deep-linking into main

2023-04-09 16:27:54 +00:00

javier commented

2023-04-09 16:27:31 +00:00

Owner

This PR contains the work done to add support to the Wikipedia app to show a custom location in the map of the Places view coming from a places deep link.

To provide further details about the work:

implemented the handling of location coordinates coming from a URL inside the function that generates a NSUSerActivity instance out of places deep links;
added the wmf_locationFromURL property to the NSUSerActivity via an extension that returns a CLLocation instance with latitude and longitude coordinates if provided;
implemented the "centerMap(onLocation:)" function in the PlacesViewController view controller that, essentially, center the map of this view controller to a given location;
improved the handling of a places user activity in the WMFAppViewController view controller to center the map in case a location has been provided via a deep link;
fixed some duplicated code that was blocking the test from compiling.

This PR contains the work done to add support to the **Wikipedia** app to show a custom location in the map of the *Places* view coming from a places deep link. To provide further details about the work: - [x] implemented the handling of location coordinates coming from a URL inside the function that generates a `NSUSerActivity` instance out of *places* deep links; - [x] added the `wmf_locationFromURL` property to the `NSUSerActivity` via an extension that returns a `CLLocation` instance with latitude and longitude coordinates if provided; - [x] implemented the "centerMap(onLocation:)" function in the `PlacesViewController` view controller that, essentially, center the map of this view controller to a given location; - [x] improved the handling of a *places* user activity in the `WMFAppViewController` view controller to center the map in case a location has been provided via a deep link; - [x] fixed some duplicated code that was blocking the test from compiling.

javier added 5 commits 2023-04-09 16:27:32 +00:00