rock-n-code/deep-linking-sample
rock-n-code/deep-linking-sample
1
0
Fork 0
Code Pull Requests Releases 2 Wiki Activity

[Feature] Open Wikipedia app #12

Merged
javier merged 6 commits from feature/open-wikipedia-app into main 2023-04-12 23:07:43 +00:00
Conversation 0 Commits 6 Files Changed 11 +119 -30
javier commented 2023-04-12 23:07:21 +00:00
Owner
Copy Link

This PR contains the work done to open the Places view of the Wikipedia app with the screen centered on the coordinates from a selected location in the LocationsListViewController view controller.

To give further details about the work done:

  • implemented the wikipediaPlacesURL property in the Location+URLs extension;
  • improved the LocationsListCoordination protocol and the LocationsListCoordinator coordinator to support the opening of the Wikipedia app;
  • improved the LocationsListViewModeling protocol and the LocationsListViewModel view model to support the opening of the Wikipedia app;
  • implemented the "tableView(_: didSelectAt: )" function in the LocationsListViewController view controller;
  • added the "wikipedia" to the Queried URL schemes in the Info.plist file to support querying to the Wikipedia app;
  • improved the naming of some properties and functions in the LocationsAddCoordination, LocationsListCoordination, and LocationsListViewModeling protocols.
This PR contains the work done to open the *Places* view of the **Wikipedia** app with the screen centered on the coordinates from a selected location in the `LocationsListViewController` view controller. To give further details about the work done: - [x] implemented the `wikipediaPlacesURL` property in the `Location+URLs` extension; - [x] improved the `LocationsListCoordination` protocol and the `LocationsListCoordinator` coordinator to support the opening of the Wikipedia app; - [x] improved the `LocationsListViewModeling` protocol and the `LocationsListViewModel` view model to support the opening of the Wikipedia app; - [x] implemented the "tableView(_: didSelectAt: )" function in the `LocationsListViewController` view controller; - [x] added the "wikipedia" to the Queried URL schemes in the Info.plist file to support querying to the Wikipedia app; - [x] improved the naming of some properties and functions in the `LocationsAddCoordination`, `LocationsListCoordination`, and `LocationsListViewModeling` protocols.
javier self-assigned this 2023-04-12 23:07:21 +00:00
javier added 6 commits 2023-04-12 23:07:22 +00:00
javier merged commit 57f4b3c237 into main 2023-04-12 23:07:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/deep-linking-sample#12
No description provided.
Delete Branch "feature/open-wikipedia-app"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?