[Setup] App architecture #9

Merged

javier merged 18 commits from setup/app-architecture into main 2023-04-11 22:14:40 +00:00

Conversation 0 Commits 18 Files Changed 29 +793 -286

javier commented 2023-04-11 22:12:50 +00:00

Owner

Copy Link

This PR contains the work done to put in the app a MVVM-C architecture plus other small fixes in the Library libraries.

To give further details about the work done:

• remove the SceneDelegate delegate;
• implemented the WindowRouter, PushNavigationRouter, and ModalNavigationRouter routers in the Core library;
• defined the LocationsAddCoordination and LocationsListCoordination protocols;
• defined the LocationsAddViewModeling and LocationsListViewModeling protocols;
• implemented the LocationsListCoordinator and LocationsAddCoordinator coordinators;
• implemented the LocationsAddViewController view controller and LocationsAddViewModel view model;
• implemented the LocationsListViewController view controller and LocationsListViewModel view model;
• implemented the BaseViewController base view controller;
• implemented the persistence and remote properties in the DependencyService+Keys extension;
• renamed the LocationsService service and the LocationsClient client in the Remote library as RemoteService and RemoteClient respectively;
• amended some documentation in the Core library.

This PR contains the work done to put in the app a **MVVM-C** architecture plus other small fixes in the `Library` libraries. To give further details about the work done: - [x] remove the `SceneDelegate` delegate; - [x] implemented the `WindowRouter`, `PushNavigationRouter`, and `ModalNavigationRouter` routers in the `Core` library; - [x] defined the `LocationsAddCoordination` and `LocationsListCoordination` protocols; - [x] defined the `LocationsAddViewModeling` and `LocationsListViewModeling` protocols; - [x] implemented the `LocationsListCoordinator` and `LocationsAddCoordinator` coordinators; - [x] implemented the `LocationsAddViewController` view controller and `LocationsAddViewModel` view model; - [x] implemented the `LocationsListViewController` view controller and `LocationsListViewModel` view model; - [x] implemented the `BaseViewController` base view controller; - [x] implemented the `persistence` and `remote` properties in the `DependencyService+Keys` extension; - [x] renamed the `LocationsService` service and the `LocationsClient` client in the `Remote` library as `RemoteService` and `RemoteClient` respectively; - [x] amended some documentation in the `Core` library.

javier added 18 commits 2023-04-11 22:12:51 +00:00

Removed the SceneDelegate delegate. c3fc42d724

Implemented the WindowRouter router in the Core library. 30bb62e795

Created the LocationsListViewModel view model. 0fe40095c7

Renamed the ViewController view controller as LocationsListViewController and conformed it to the View protocol from the Core library. 229bd1b878

Implemented a bare-bone LocationsListsCoordinator coordinator. a55ba672da

Integrated a WindowRouter router and a LocationsListCoordinator coordinator into the AppDelegate delegate to present the coordinator at launch time. b4b99dfa87

Moved the LocationsListViewModel view model and LocationsListViewController view controller into its own folder inside the Screens group. 0dfbe62603

Created the LocationsAddViewModel view model. 2d068de8ed

Created the LocationsAddViewController view controller. 8deadffe2a

Implemented the BaseNavigationRouter class in the Core library. 8a0c7d95e0

Renamed the NavigationRouter router in the Core library as PushNavigationRouter router and implemented the inheritance from the BaseNavigationRouter class. 0d824637ae

implemented the ModalNavigationRouter router in the Core library that inherits from the BaseNavigationRouter class. c16b40652f

Removed the View and ViewModel protocols from the Core library. 5e5653bbe2

Defined the LocationsListCoordinable protocol and conformed the LocationsListCoordinator coordinator to it. 9b14b79ea2

Work done so far in the app architecture setup. b9417244a4

Implemented the coordinator flow for LocationsList and LocationAdd screens. b73a8e1010

Renamed the LocationsService service and LocationsClient client in the Remote library as RemoteService and RemoteClient respectively. 83ed85b755

Implemented the "persistence" and "remote" properties of the DependencyService service in the Dependency+Keys extension. cb5b4743f2

javier merged commit 43c156a2c3 into main 2023-04-11 22:14:40 +00:00

javier referenced this issue from a commit 2023-04-11 22:14:41 +00:00

[Setup] App architecture (#9)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rock-n-code/deep-linking-sample#9

No description provided.