rock-n-code/my-files-sample
rock-n-code/my-files-sample
1
0
Fork 0
Code Releases Wiki Activity

Added support for the "unauthorized" response status in the APIClient client.

Browse Source
This commit is contained in:
Javier Cicchelli 2022-12-04 17:59:06 +01:00
parent 29e19d8fdf
commit 7670d5b7a0
3 changed files with 56 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/Sources/APIService/Enumerations/ResponseStatus.swift
View File

@ -11,6 +11,7 @@ enum ResponseStatus: Int {
case created = 201
case noContent = 204
case badRequest = 400
case unauthorized = 401
case forbidden = 403
case notFound = 404
}

6
Libraries/Sources/APIService/Structs/APIClient.swift
View File

@ -50,7 +50,8 @@ extension APIClient: Client {
throw APIClientError.notSupported
case .badRequest:
throw APIClientError.itemAlreadyExist
case .forbidden:
case .unauthorized,
.forbidden:
throw APIClientError.authenticationFailed
case .notFound:
throw APIClientError.itemDoesNotExist
@ -79,7 +80,8 @@ extension APIClient: Client {
throw APIClientError.notSupported
case .badRequest:
throw APIClientError.itemIsNotFile
case .forbidden:
case .unauthorized,
.forbidden:
throw APIClientError.authenticationFailed
case .notFound:
throw APIClientError.itemDoesNotExist

51
Libraries/Tests/APIServiceTests/Cases/Structs/APIClient+RequestTests.swift
View File

@ -157,6 +157,31 @@ final class APIClientRequestTests: XCTestCase {
}
}
func test_withSomeEndpoint_andSomeModel_whenResponseStatusUnauthorized() async throws {
// GIVEN
let endpoint = GetMeEndpoint(
username: "username",
password: "password"
)
url = try makeURLRequest(endpoint: endpoint).url
MockURLProtocol.mockData[url] = MockURLResponse(
status: .unauthorized,
headers: [:],
data: nil
)
// WHEN & THEN
do {
_ = try await client.request(endpoint: endpoint, model: Me.self)
} catch APIClientError.authenticationFailed {
XCTAssertTrue(true)
} catch {
XCTAssertTrue(false)
}
}
func test_withSomeEndpoint_andSomeModel_whenResponseStatusForbidden() async throws {
// GIVEN
let endpoint = GetMeEndpoint(
@ -333,6 +358,32 @@ final class APIClientRequestTests: XCTestCase {
}
}
func test_withSomeEndpoint_whenResponseStatusUnauthorized() async throws {
// GIVEN
let endpoint = GetDataEndpoint(
itemId: UUID().uuidString,
username: "username",
password: "password"
)
url = try makeURLRequest(endpoint: endpoint).url
MockURLProtocol.mockData[url] = MockURLResponse(
status: .unauthorized,
headers: [:],
data: nil
)
// WHEN & THEN
do {
try await client.request(endpoint: endpoint)
} catch APIClientError.authenticationFailed {
XCTAssertTrue(true)
} catch {
XCTAssertTrue(false)
}
}
func test_withSomeEndpoint_whenResponseStatusForbidden() async throws {
// GIVEN
let endpoint = GetDataEndpoint(