rock-n-code/swift-libs
rock-n-code/swift-libs
1
0
Fork 0
Code Issues 1 Pull Requests Releases 13 Wiki Activity

[Bugfix] Mobile platform builds #11

Merged
javier merged 6 commits from bugfix/mobile-platforms-build into main 2023-04-25 13:38:31 +00:00
Conversation 0 Commits 6 Files Changed 6 +99 -24
javier commented 2023-04-25 13:38:03 +00:00
Owner
Copy Link

This PR contains the work done to address the issue #10, that was raised based on the build logs from publishing the package in the Swift Package Index.

To provide further details about the work done:

  • fixed the Router protocol that was causing a compilation issue on watchOS platforms;
  • downgraded the swift tools version in the Package file to v5.5;
  • bumped the minimum platform version in the Package file to restrict support to the last 2 major releases;
  • written the Installation section in the README file;
  • updated the project logo assets, including light and dark versions;
  • updated the project logo in the README file and added support for both light and dark modes.
This PR contains the work done to address the issue #10, that was raised based on the build logs from publishing the package in the Swift Package Index. To provide further details about the work done: - [x] fixed the `Router` protocol that was causing a compilation issue on *watchOS* platforms; - [x] downgraded the swift tools version in the `Package` file to v5.5; - [x] bumped the minimum platform version in the `Package` file to restrict support to the last 2 major releases; - [x] written the *Installation* section in the `README` file; - [x] updated the project logo assets, including light and dark versions; - [x] updated the project logo in the `README` file and added support for both light and dark modes.
javier self-assigned this 2023-04-25 13:38:03 +00:00
javier added 6 commits 2023-04-25 13:38:04 +00:00
javier merged commit 4a1fab2f8a into main 2023-04-25 13:38:31 +00:00
javier deleted branch bugfix/mobile-platforms-build 2023-04-25 13:38:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/swift-libs#11
No description provided.
Delete Branch "bugfix/mobile-platforms-build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?