rock-n-code/swift-libs
1
0
Fork 0
Code Issues 1 Pull Requests Releases 13 Wiki Activity

[Feature] Coordinator protocols #2

Merged
javier merged 5 commits from target/coordinator into main 2023-04-16 14:42:43 +00:00
Conversation 0 Commits 5 Files Changed 9
+669 -1
javier commented 2023-04-16 14:42:20 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to define the Coordinator and the Router public protocols, and also implemented a few concrete router implementations tailored for the UIKit framework.

To provide further details about the work done:

  • define a new, dedicated Coordinator target in the Package file;
  • define the Coordinator and the Router public protocols used to implement the coordinator pattern;
  • implemented some UIKit specific routers to use on the iOS platform: ModalNavigationRouter, PushNavigationRouter and the WindowRouter concrete routers.
This PR contains the work done to define the `Coordinator` and the `Router` public protocols, and also implemented a few concrete router implementations tailored for the **UIKit** framework. To provide further details about the work done: - [x] define a new, dedicated `Coordinator` target in the `Package` file; - [x] define the `Coordinator` and the `Router` public protocols used to implement the coordinator pattern; - [x] implemented some **UIKit** specific routers to use on the **iOS** platform: `ModalNavigationRouter`, `PushNavigationRouter` and the `WindowRouter` concrete routers.
javier self-assigned this 2023-04-16 14:42:20 +00:00
javier added 5 commits 2023-04-16 14:42:20 +00:00
Defined the Coordinator target in the Package file. 77a2472dbf
Defined the Coordinator and the Router public protocols. 3ed652061b
Implemented the WindowRouter router for iOS platform. a9248a528b
Implemented the PushNavigationRouter and the ModalNavigationRouter routers for iOS platforms, with its respective BaseNavigationRouter base class. ecf036ec78
Improved some documentation in the ModalNavigationRouter and the PushNavigationRouter routers. 061ad36a8b
javier changed title from [Feature] Coordinator protocol and iOS concrete routers to [Feature] Coordinator protocols 2023-04-16 14:42:33 +00:00
javier merged commit 12add7bf30 into main 2023-04-16 14:42:43 +00:00
javier deleted branch target/coordinator 2023-04-16 14:42:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/swift-libs#2
Delete Branch "target/coordinator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?