rock-n-code/swift-libs
1
0
Fork 0
Code Issues 1 Pull Requests Releases 13 Wiki Activity

[Enhancement] String localisation #21

Merged
javier merged 6 commits from enhancement/localisable-strings into main 2023-05-19 16:58:51 +00:00
Conversation 0 Commits 6 Files Changed 8
+370 -5
javier commented 2023-05-19 16:58:40 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to provide string localisation support for the Core library.

To provide further details about the work done:

  • implemented the localisation(for:) function for the Bundle+LocalisationBundle extension;
  • implemented the localise(for: in: value: table:) function for the String+Localisation extension;
  • defined English as the default localisation language in the Package.swift file;
  • added the "vscode" target to the Makefile file.
This PR contains the work done to provide string localisation support for the `Core` library. To provide further details about the work done: - [x] implemented the `localisation(for:)` function for the `Bundle+LocalisationBundle` extension; - [x] implemented the `localise(for: in: value: table:)` function for the `String+Localisation` extension; - [x] defined English as the default localisation language in the `Package.swift` file; - [x] added the "vscode" target to the `Makefile` file.
javier added the enhancement label 2023-05-19 16:58:40 +00:00
javier self-assigned this 2023-05-19 16:58:40 +00:00
javier added 6 commits 2023-05-19 16:58:41 +00:00
Implemented the "localisation(for:)" function of the Bundle+LocalisationBundle extension for the Core library. 9913c73174
Defined English as the default localisation language in the Package file. 8631e1067c
Added the "vscode" target to the Makefile file. edfcb049ea
Written the documentation for the "localisation(for:)" function of the Bundle+LocalisationBundle extension. 41f019d7b2
Implemented the "localise(for: in: value: table:)" function for the String+Localisation extension of the Core library. dfbd892975
Fixed the documentation of the "localise(for: in: value: table:)" function of the String+Localisation extension. 86319561bf
javier merged commit 060d8a84a9 into main 2023-05-19 16:58:51 +00:00
javier deleted branch enhancement/localisable-strings 2023-05-19 16:58:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/swift-libs#21