rock-n-code/swift-libs
1
0
Fork 0
Code Issues 1 Pull Requests Releases 13 Wiki Activity

[Bugfix] Communications #7

Merged
javier merged 4 commits from bugfix/communications into main 2023-04-18 22:55:25 +00:00
Conversation 0 Commits 4 Files Changed 5
+63 -23
javier commented 2023-04-18 22:55:13 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to implement some bugfixes to the existing source code related to the Communications library of this package.

To provide further details about the work done:

  • removed an unnecessary function from the Client public protocol;
  • moved the MakeURLRequestError public error to its own file;
  • added the parameters property to the Endpoint public protocol;
  • added support for the parameters handling in the MakeURLRequestUseCase use case.
This PR contains the work done to implement some bugfixes to the existing source code related to the `Communications` library of this package. To provide further details about the work done: - [x] removed an unnecessary function from the `Client` public protocol; - [x] moved the `MakeURLRequestError` public error to its own file; - [x] added the `parameters` property to the `Endpoint` public protocol; - [x] added support for the parameters handling in the `MakeURLRequestUseCase` use case.
javier self-assigned this 2023-04-18 22:55:13 +00:00
javier added 4 commits 2023-04-18 22:55:14 +00:00
Removed the "request(endpoint: )" function from the Client public protocol. 9ee4afc69d
Moved the MakeURLRequestError error from the MakeURLRequestUseCase use case to its own file. 6277f95661
Added the "parameters" property to the Endpoint public protocol. e5b511d226
Added support for parameters handling in the MakeURLRequestUseCase use case. 470478c3d5
javier merged commit d8163ab0de into main 2023-04-18 22:55:25 +00:00
javier deleted branch bugfix/communications 2023-04-18 22:55:25 +00:00
javier referenced this issue from a commit 2023-04-18 22:55:25 +00:00
[Bugfix] Communications (#7)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/swift-libs#7
Delete Branch "bugfix/communications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?