Javier Cicchelli
d8163ab0de
This PR contains the work done to implement some bugfixes to the existing source code related to the `Communications` library of this package. To provide further details about the work done: - [x] removed an unnecessary function from the `Client` public protocol; - [x] moved the `MakeURLRequestError` public error to its own file; - [x] added the `parameters` property to the `Endpoint` public protocol; - [x] added support for the parameters handling in the `MakeURLRequestUseCase` use case. Co-authored-by: Javier Cicchelli <javier@rock-n-code.com> Reviewed-on: #7
144 lines
4.5 KiB
Swift
144 lines
4.5 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This source file is part of the SwiftLibs open source project
|
|
//
|
|
// Copyright (c) 2023 Röck+Cöde VoF. and the SwiftLibs project authors
|
|
// Licensed under the EUPL 1.2 or later.
|
|
//
|
|
// See LICENSE.txt for license information
|
|
// See CONTRIBUTORS.txt for the list of SwiftLibs project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import Communications
|
|
import Foundation
|
|
import XCTest
|
|
|
|
final class MakeURLRequestUseCaseTests: XCTestCase {
|
|
|
|
// MARK: Properties
|
|
|
|
private let makeURLRequest = MakeURLRequestUseCase()
|
|
|
|
// MARK: Test cases
|
|
|
|
func test_withEndpoint_initialisedByDefault() throws {
|
|
// GIVEN
|
|
let endpoint = TestEndpoint()
|
|
|
|
// WHEN
|
|
let result = try makeURLRequest(endpoint: endpoint)
|
|
|
|
// THEN
|
|
XCTAssertNotNil(result)
|
|
XCTAssertEqual(result.url?.absoluteString, "http://www.something.com/path/to/endpoint")
|
|
XCTAssertEqual(result.httpMethod, HTTPRequestMethod.get.rawValue)
|
|
XCTAssertEqual(result.allHTTPHeaderFields, [:])
|
|
XCTAssertNil(result.httpBody)
|
|
}
|
|
|
|
func test_withEndpoint_initialisedWithPort() throws {
|
|
// GIVEN
|
|
let endpoint = TestEndpoint(port: 8080)
|
|
|
|
// WHEN
|
|
let result = try makeURLRequest(endpoint: endpoint)
|
|
|
|
// THEN
|
|
XCTAssertNotNil(result)
|
|
XCTAssertEqual(result.url?.absoluteString, "http://www.something.com:8080/path/to/endpoint")
|
|
XCTAssertEqual(result.httpMethod, HTTPRequestMethod.get.rawValue)
|
|
XCTAssertEqual(result.allHTTPHeaderFields, [:])
|
|
XCTAssertNil(result.httpBody)
|
|
}
|
|
|
|
func test_withEndpoint_initialisedWithParameters() throws {
|
|
// GIVEN
|
|
let endpoint = TestEndpoint(parameters: [
|
|
"someParameter": "someValue",
|
|
"anotherParameter": nil,
|
|
"otherParameter": "yetAnotherValue"
|
|
])
|
|
|
|
// WHEN
|
|
let result = try makeURLRequest(endpoint: endpoint)
|
|
|
|
// THEN
|
|
XCTAssertNotNil(result)
|
|
XCTAssertEqual(result.url?.absoluteString, "http://www.something.com/path/to/endpoint?anotherParameter&otherParameter=yetAnotherValue&someParameter=someValue")
|
|
XCTAssertEqual(result.httpMethod, HTTPRequestMethod.get.rawValue)
|
|
XCTAssertEqual(result.allHTTPHeaderFields, [:])
|
|
XCTAssertNil(result.httpBody)
|
|
}
|
|
|
|
func test_withEndpoint_initialisedWithHeaders() throws {
|
|
// GIVEN
|
|
let endpoint = TestEndpoint(headers: [
|
|
"aHeader": "aValueForHead",
|
|
"someOtherHeader": "someValueForOtherHeader"
|
|
])
|
|
|
|
// WHEN
|
|
let result = try makeURLRequest(endpoint: endpoint)
|
|
|
|
// THEN
|
|
XCTAssertNotNil(result)
|
|
XCTAssertEqual(result.url?.absoluteString, "http://www.something.com/path/to/endpoint")
|
|
XCTAssertEqual(result.httpMethod, HTTPRequestMethod.get.rawValue)
|
|
XCTAssertEqual(result.allHTTPHeaderFields, [
|
|
"aHeader": "aValueForHead",
|
|
"someOtherHeader": "someValueForOtherHeader"
|
|
])
|
|
XCTAssertNil(result.httpBody)
|
|
}
|
|
|
|
func test_withEndpoint_initialisedWithBody() throws {
|
|
// GIVEN
|
|
let data = "This is some data for a body of a request".data(using: .utf8)
|
|
let endpoint = TestEndpoint(body: data)
|
|
|
|
// WHEN
|
|
let result = try makeURLRequest(endpoint: endpoint)
|
|
|
|
// THEN
|
|
XCTAssertNotNil(result)
|
|
XCTAssertEqual(result.url?.absoluteString, "http://www.something.com/path/to/endpoint")
|
|
XCTAssertEqual(result.httpMethod, HTTPRequestMethod.get.rawValue)
|
|
XCTAssertEqual(result.allHTTPHeaderFields, [:])
|
|
XCTAssertEqual(result.httpBody, data)
|
|
XCTAssertNotNil(data)
|
|
}
|
|
|
|
}
|
|
|
|
// MARK: - TestEndpoint
|
|
|
|
private struct TestEndpoint: Endpoint {
|
|
|
|
// MARK: Properties
|
|
|
|
let scheme: String = "http"
|
|
let host: String = "www.something.com"
|
|
let port: Int?
|
|
let path: String = "/path/to/endpoint"
|
|
let parameters: Parameters
|
|
let method: HTTPRequestMethod = .get
|
|
let headers: Headers
|
|
let body: Data?
|
|
|
|
// MARK: Initialisers
|
|
|
|
init(
|
|
port: Int? = nil,
|
|
parameters: Parameters = [:],
|
|
headers: Headers = [:],
|
|
body: Data? = nil
|
|
) {
|
|
self.port = port
|
|
self.parameters = parameters
|
|
self.headers = headers
|
|
self.body = body
|
|
}
|
|
|
|
}
|