rock-n-code/amiibo-service
1
0 Fork 0
Code Issues Pull Requests Releases 18 Activity

Some fixes to the live test suite (#32)
CI / Build and test (push) Canceled after 0s
Documentation / Build documentation (push) Canceled after 0s
Documentation / Deploy to GitHub Pages (push) Canceled after 0s

Browse Source 
This PR contains the work done to fix the live test suite, which started failing once the Amiibo API began returning Switch 2 games, and tidies the test suite around it.

### Changes

- **Live tests:** replaced the assertion that the first amiibo has no Switch 2 games with a usage check, matching the other platforms. The live data now includes Switch 2 entries for most amiibos.
- **Live tests:** refreshed the minimum item counts and the earliest accepted last-updated date to the values observed in October 2026, and documented in the README how to refresh them.
- **All tests:** moved test descriptions from `@Test("...")` strings into backticked function names, and aligned every case on the same GIVEN/WHEN/THEN structure.
- **Live client:** replaced the TODO about DocC inherited docs with a note. The compiler does not inherit documentation for protocol witnesses, so the repeated doc comments stay on purpose.

Reviewed-on: #32
Co-authored-by: Javier Cicchelli <javier@rock-n-code.com>
This commit was merged in pull request #32.
This commit is contained in:
javier authored and Javier Cicchelli committed 2026-10-25 21:53:31 +00:00
1 parent 13b9c74a38
commit 4cbac015b1
8 files changed
+138 -134
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

README.md
+10
View File
@@ -133,6 +133,16 @@ AMIIBO_LIVE_TESTS=1 swift test
In Xcode, set the variable in the scheme's **Test** action. In Xcode, set the variable in the scheme's **Test** action.
The live tests compare the responses against baselines recorded from the service: minimum item counts per endpoint and the earliest accepted last-updated date. These live in the `Int` extension at the bottom of `AmiiboServiceLiveTests.swift` and in the `get the last updated timestamp` test. Refresh them occasionally by fetching the current totals and the current timestamp from the service, then updating the constants and their `as of` notes:
```shell
for endpoint in amiibo amiiboseries type character gameseries; do
printf '%s: ' "$endpoint"
curl -s "https://www.amiiboapi.org/api/$endpoint/" | python3 -c 'import json,sys; print(len(json.load(sys.stdin)["amiibo"]))'
done
curl -s https://www.amiiboapi.org/api/lastupdated/
```
## Documentation ## Documentation
See the [online documentation](https://rock-n-code.github.io/amiibo-service/documentation/amiiboservice/). See the [online documentation](https://rock-n-code.github.io/amiibo-service/documentation/amiiboservice/).
Sources/AmiiboService/Public/Clients/AmiiboLiveClient.swift
+2 -1
View File
@@ -54,7 +54,8 @@ public struct AmiiboLiveClient: Sendable {
} }
// MARK: - AmiiboClient // MARK: - AmiiboClient
// TODO: Remove the documentation from the functions inside the following extension as the `--enable-inherited-docs` flag when generating DocC documentation is not working as intended (?). // NOTE: The `AmiiboClient` documentation is repeated below on purpose, as the compiler does not inherit
// documentation for protocol witnesses and DocC would otherwise render these functions undocumented.
extension AmiiboLiveClient: AmiiboClient { extension AmiiboLiveClient: AmiiboClient {
Tests/AmiiboService/Cases/Internal/Transcoders/ISODateTimeTranscoderTests.swift
+8 -8
View File
@@ -25,8 +25,8 @@ struct ISODateTimeTranscoderTests {
// MARK: Decode tests // MARK: Decode tests
@Test("decodes a timestamp as UTC") @Test
func decodesTimestamp() throws { func `decodes a timestamp as UTC`() throws {
// GIVEN // GIVEN
let string = "2026-07-24T12:34:56.123000" let string = "2026-07-24T12:34:56.123000"
@@ -37,8 +37,8 @@ struct ISODateTimeTranscoderTests {
#expect(abs(date.timeIntervalSince(.utc(2026, 7, 24, 12, 34, 56)) - 0.123) < 0.001) #expect(abs(date.timeIntervalSince(.utc(2026, 7, 24, 12, 34, 56)) - 0.123) < 0.001)
} }
@Test("decodes a date-only string as midnight UTC") @Test
func decodesDate() throws { func `decodes a date-only string as midnight UTC`() throws {
// GIVEN // GIVEN
let string = "2014-11-21" let string = "2014-11-21"
@@ -49,10 +49,10 @@ struct ISODateTimeTranscoderTests {
#expect(date == .utc(2014, 11, 21)) #expect(date == .utc(2014, 11, 21))
} }
@Test("throws a decoding error for an unsupported string", arguments: [ @Test(arguments: [
"", "2014-11", "2014-11-21T12:34:56", "2014-11-21T12:34:56Z", "21/11/2014", "yesterday" "", "2014-11", "2014-11-21T12:34:56", "2014-11-21T12:34:56Z", "21/11/2014", "yesterday"
]) ])
func throwsForUnsupportedString(string: String) { func `throws a decoding error for an unsupported string`(string: String) {
// GIVEN // GIVEN
// WHEN // WHEN
// THEN // THEN
@@ -63,8 +63,8 @@ struct ISODateTimeTranscoderTests {
// MARK: Encode tests // MARK: Encode tests
@Test("encodes a date as a timestamp") @Test
func encodesTimestamp() throws { func `encodes a date as a timestamp`() throws {
// GIVEN // GIVEN
let date: Date = .utc(2026, 7, 24, 12, 34, 56) let date: Date = .utc(2026, 7, 24, 12, 34, 56)
Tests/AmiiboService/Cases/Public/Clients/AmiiboLiveClientTests.swift
+46 -52
View File
@@ -22,8 +22,8 @@ struct AmiiboLiveClientTests {
// MARK: Server URL tests // MARK: Server URL tests
@Test("resolves the server URL defined in the OpenAPI specification") @Test
func serverURLResolves() throws { func `resolves the server URL defined in the OpenAPI specification`() throws {
// GIVEN // GIVEN
// WHEN // WHEN
let url = try Servers.Server1.url() let url = try Servers.Server1.url()
@@ -32,8 +32,8 @@ struct AmiiboLiveClientTests {
#expect(url.absoluteString == "https://www.amiiboapi.org/api") #expect(url.absoluteString == "https://www.amiiboapi.org/api")
} }
@Test("uses the server URL from the OpenAPI specification") @Test
func serverURLMatchesSpecification() throws { func `uses the server URL from the OpenAPI specification`() throws {
// GIVEN // GIVEN
let expected = try Servers.Server1.url() let expected = try Servers.Server1.url()
@@ -46,14 +46,11 @@ struct AmiiboLiveClientTests {
// MARK: Error mapping tests // MARK: Error mapping tests
@Test( @Test(arguments: zip(
"maps an error thrown by the transport to the matching service error", TransportErrors.thrown,
arguments: zip( TransportErrors.expected
TransportErrors.thrown, ))
TransportErrors.expected func `maps an error thrown by the transport to the matching service error`(
)
)
func mapsTransportError(
thrown: any Error, thrown: any Error,
expected: AmiiboServiceError expected: AmiiboServiceError
) async { ) async {
@@ -67,14 +64,11 @@ struct AmiiboLiveClientTests {
} }
} }
@Test( @Test(arguments: zip(
"maps a response status to the matching service error", Responses.failing,
arguments: zip( Responses.expected
Responses.failing, ))
Responses.expected func `maps a response status to the matching service error`(
)
)
func mapsResponseStatus(
response: (status: Int, json: String?), response: (status: Int, json: String?),
expected: AmiiboServiceError expected: AmiiboServiceError
) async { ) async {
@@ -93,8 +87,8 @@ struct AmiiboLiveClientTests {
// MARK: Get Amiibos tests // MARK: Get Amiibos tests
@Test("returns amiibos sorted by identifier") @Test
func getAmiibosSorted() async throws { func `returns amiibos sorted by identifier`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibos)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibos))
@@ -106,8 +100,8 @@ struct AmiiboLiveClientTests {
#expect(amiibos.map(\.name) == ["Mario", "Zelda"]) #expect(amiibos.map(\.name) == ["Mario", "Zelda"])
} }
@Test("returns a single amiibo when the response holds an object") @Test
func getAmiibosSingle() async throws { func `returns a single amiibo when the response holds an object`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibo)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibo))
@@ -128,8 +122,8 @@ struct AmiiboLiveClientTests {
#expect(amiibo.platform == nil) #expect(amiibo.platform == nil)
} }
@Test("returns no amiibos when the response holds null") @Test
func getAmiibosNull() async throws { func `returns no amiibos when the response holds null`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibosNull)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibosNull))
@@ -140,8 +134,8 @@ struct AmiiboLiveClientTests {
#expect(amiibos.isEmpty) #expect(amiibos.isEmpty)
} }
@Test("returns no amiibos when the response holds an empty list") @Test
func getAmiibosEmpty() async throws { func `returns no amiibos when the response holds an empty list`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibosEmpty)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibosEmpty))
@@ -152,8 +146,8 @@ struct AmiiboLiveClientTests {
#expect(amiibos.isEmpty) #expect(amiibos.isEmpty)
} }
@Test("decodes release dates as midnight UTC, and missing or null ones as nil") @Test
func getAmiibosRelease() async throws { func `decodes release dates as midnight UTC, and missing or null ones as nil`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibos)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiibos))
@@ -171,8 +165,8 @@ struct AmiiboLiveClientTests {
#expect(zelda.release.japan == nil) #expect(zelda.release.japan == nil)
} }
@Test("maps related games and usages into the platform") @Test
func getAmiibosPlatform() async throws { func `maps related games and usages into the platform`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiiboWithGames)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.amiiboWithGames))
@@ -192,8 +186,8 @@ struct AmiiboLiveClientTests {
#expect(platform.wiiU.first?.usages == nil) #expect(platform.wiiU.first?.usages == nil)
} }
@Test("encodes the amiibo filter as query parameters") @Test
func getAmiibosQuery() async throws { func `encodes the amiibo filter as query parameters`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
let path = request.path ?? "" let path = request.path ?? ""
@@ -229,8 +223,8 @@ struct AmiiboLiveClientTests {
)) ))
} }
@Test("omits nil filter values from the query") @Test
func getAmiibosEmptyQuery() async throws { func `omits nil filter values from the query`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/amiibo") #expect(request.path == "/amiibo")
@@ -245,8 +239,8 @@ struct AmiiboLiveClientTests {
// MARK: Key-name endpoints tests // MARK: Key-name endpoints tests
@Test("returns amiibo series sorted by key") @Test
func getAmiiboSeriesSorted() async throws { func `returns amiibo series sorted by key`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.keyNameList)) let client = AmiiboLiveClient(transport: StubTransport(status: .ok, json: JSON.keyNameList))
@@ -257,8 +251,8 @@ struct AmiiboLiveClientTests {
#expect(series == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")]) #expect(series == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")])
} }
@Test("returns a single amiibo series when the response holds an object") @Test
func getAmiiboSeriesSingle() async throws { func `returns a single amiibo series when the response holds an object`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/amiiboseries?key=0x01") #expect(request.path == "/amiiboseries?key=0x01")
@@ -273,8 +267,8 @@ struct AmiiboLiveClientTests {
#expect(series == [.init(key: "0x01", name: "First")]) #expect(series == [.init(key: "0x01", name: "First")])
} }
@Test("returns amiibo types sorted by key") @Test
func getAmiiboTypesSorted() async throws { func `returns amiibo types sorted by key`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/type") #expect(request.path == "/type")
@@ -289,8 +283,8 @@ struct AmiiboLiveClientTests {
#expect(types == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")]) #expect(types == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")])
} }
@Test("returns game characters sorted by key") @Test
func getGameCharactersSorted() async throws { func `returns game characters sorted by key`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/character?name=First") #expect(request.path == "/character?name=First")
@@ -305,8 +299,8 @@ struct AmiiboLiveClientTests {
#expect(characters == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")]) #expect(characters == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")])
} }
@Test("returns game series sorted by key") @Test
func getGameSeriesSorted() async throws { func `returns game series sorted by key`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/gameseries") #expect(request.path == "/gameseries")
@@ -321,8 +315,8 @@ struct AmiiboLiveClientTests {
#expect(series == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")]) #expect(series == [.init(key: "0x00", name: "Second"), .init(key: "0x01", name: "First")])
} }
@Test("throws notFound when a key-name endpoint matches nothing") @Test
func getKeyNameNotFound() async { func `throws notFound when a key-name endpoint matches nothing`() async {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .notFound, json: JSON.notFound)) let client = AmiiboLiveClient(transport: StubTransport(status: .notFound, json: JSON.notFound))
@@ -335,8 +329,8 @@ struct AmiiboLiveClientTests {
// MARK: Get Last Updated tests // MARK: Get Last Updated tests
@Test("returns the last updated timestamp as UTC") @Test
func getLastUpdated() async throws { func `returns the last updated timestamp as UTC`() async throws {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport { request in let client = AmiiboLiveClient(transport: StubTransport { request in
#expect(request.path == "/lastupdated") #expect(request.path == "/lastupdated")
@@ -351,8 +345,8 @@ struct AmiiboLiveClientTests {
#expect(lastUpdated == .utc(2026, 7, 24, 12, 34, 56)) #expect(lastUpdated == .utc(2026, 7, 24, 12, 34, 56))
} }
@Test("throws notAvailable when the last updated endpoint fails") @Test
func getLastUpdatedNotAvailable() async { func `throws notAvailable when the last updated endpoint fails`() async {
// GIVEN // GIVEN
let client = AmiiboLiveClient(transport: StubTransport(status: .internalServerError)) let client = AmiiboLiveClient(transport: StubTransport(status: .internalServerError))
Tests/AmiiboService/Cases/Public/Filters/FilterConformanceTests.swift
+6 -6
View File
@@ -20,8 +20,8 @@ struct FilterConformanceTests {
// MARK: Equatable tests // MARK: Equatable tests
@Test("compares amiibo filters by value") @Test
func amiiboFilterEquality() { func `compares amiibo filters by value`() {
// GIVEN // GIVEN
// WHEN // WHEN
// THEN // THEN
@@ -31,8 +31,8 @@ struct FilterConformanceTests {
#expect(AmiiboFilter() != AmiiboFilter(showGames: true)) #expect(AmiiboFilter() != AmiiboFilter(showGames: true))
} }
@Test("compares key-name filters by value") @Test
func keyNameFilterEquality() { func `compares key-name filters by value`() {
// GIVEN // GIVEN
// WHEN // WHEN
// THEN // THEN
@@ -46,8 +46,8 @@ struct FilterConformanceTests {
// MARK: Hashable tests // MARK: Hashable tests
@Test("hashes equal filters alike") @Test
func filterHashing() { func `hashes equal filters alike`() {
// GIVEN // GIVEN
let amiiboFilters: Set = [AmiiboFilter(name: "zelda"), AmiiboFilter(name: "zelda"), AmiiboFilter(name: "mario")] let amiiboFilters: Set = [AmiiboFilter(name: "zelda"), AmiiboFilter(name: "zelda"), AmiiboFilter(name: "mario")]
let seriesFilters: Set = [AmiiboSeriesFilter(key: "0x01"), AmiiboSeriesFilter(key: "0x01"), AmiiboSeriesFilter()] let seriesFilters: Set = [AmiiboSeriesFilter(key: "0x01"), AmiiboSeriesFilter(key: "0x01"), AmiiboSeriesFilter()]
Tests/AmiiboService/Cases/Public/Models/ModelConformanceTests.swift
+8 -8
View File
@@ -21,8 +21,8 @@ struct ModelConformanceTests {
// MARK: Identifiable tests // MARK: Identifiable tests
@Test("identifies an amiibo by its identifier") @Test
func amiiboID() { func `identifies an amiibo by its identifier`() {
// GIVEN // GIVEN
let amiibos = Fixtures.amiibos let amiibos = Fixtures.amiibos
@@ -31,8 +31,8 @@ struct ModelConformanceTests {
#expect(amiibos.map(\.id) == amiibos.map(\.identifier)) #expect(amiibos.map(\.id) == amiibos.map(\.identifier))
} }
@Test("identifies key-name models by their keys") @Test
func keyNameIDs() { func `identifies key-name models by their keys`() {
// GIVEN // GIVEN
// WHEN // WHEN
// THEN // THEN
@@ -44,8 +44,8 @@ struct ModelConformanceTests {
// MARK: Codable tests // MARK: Codable tests
@Test("round-trips amiibos through JSON") @Test
func amiibosRoundTrip() throws { func `round-trips amiibos through JSON`() throws {
// GIVEN // GIVEN
let amiibos = Fixtures.amiibos let amiibos = Fixtures.amiibos
@@ -57,8 +57,8 @@ struct ModelConformanceTests {
#expect(decoded.first?.platform?.switch.first?.usages?.isEmpty == false) #expect(decoded.first?.platform?.switch.first?.usages?.isEmpty == false)
} }
@Test("round-trips key-name models through JSON") @Test
func keyNameRoundTrip() throws { func `round-trips key-name models through JSON`() throws {
// GIVEN // GIVEN
// WHEN // WHEN
// THEN // THEN
Tests/AmiiboService/Cases/Public/Services/AmiiboServiceLiveTests.swift
+12 -13
View File
@@ -181,8 +181,8 @@ struct AmiiboServiceLiveTests {
@Test @Test
func `get the last updated timestamp`() async throws { func `get the last updated timestamp`() async throws {
try await assertLastUpdated( try await assertLastUpdated(
onOrAfterDay: 24, onOrAfterDay: 22,
month: 7, month: 10,
year: 2026 year: 2026
) )
} }
@@ -221,8 +221,7 @@ private extension AmiiboServiceLiveTests {
if filter.showUsage == true { if filter.showUsage == true {
#expect(firstAmiiboPlatform.switch.first?.usages?.isEmpty == false) #expect(firstAmiiboPlatform.switch.first?.usages?.isEmpty == false)
// Given the live data is still not returning any Switch 2 games. #expect(firstAmiiboPlatform.switch2.first?.usages?.isEmpty == false)
#expect(firstAmiiboPlatform.switch2.isEmpty == true)
#expect(firstAmiiboPlatform.threeDS.first?.usages?.isEmpty == false) #expect(firstAmiiboPlatform.threeDS.first?.usages?.isEmpty == false)
#expect(firstAmiiboPlatform.wiiU.first?.usages?.isEmpty == false) #expect(firstAmiiboPlatform.wiiU.first?.usages?.isEmpty == false)
} }
@@ -584,16 +583,16 @@ enum Output {
// MARK: - Constants // MARK: - Constants
private extension Int { private extension Int {
/// A number that represents the minimum number of amiibo items expected from the live service, as of July 2026. /// A number that represents the minimum number of amiibo items expected from the live service, as of October 2026.
static let minimumAmiibos = 946 static let minimumAmiibos = 952
/// A number that represents the minimum number of amiibo series expected from the live service, as of July 2026. /// A number that represents the minimum number of amiibo series expected from the live service, as of October 2026.
static let minimumAmiiboSeries = 31 static let minimumAmiiboSeries = 32
/// A number that represents the minimum number of amiibo types expected from the live service, as of July 2026. /// A number that represents the minimum number of amiibo types expected from the live service, as of October 2026.
static let minimumAmiiboTypes = 5 static let minimumAmiiboTypes = 5
/// A number that represents the minimum number of game characters expected from the live service, as of July 2026. /// A number that represents the minimum number of game characters expected from the live service, as of October 2026.
static let minimumGameCharacters = 681 static let minimumGameCharacters = 685
/// A number that represents the minimum number of game series expected from the live service, as of July 2026. /// A number that represents the minimum number of game series expected from the live service, as of October 2026.
static let minimumGameSeries = 118 static let minimumGameSeries = 119
} }
private extension String { private extension String {
Tests/AmiiboService/Cases/Public/Services/AmiiboServiceMockTests.swift
+46 -46
View File
@@ -21,8 +21,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Amiibos tests // MARK: Get Amiibos tests
@Test("returns empty amiibos when mock provides an empty list") @Test
func getAmiibosEmpty() async throws { func `returns empty amiibos when mock provides an empty list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiibos: [])) let service = AmiiboService(client: AmiiboMockClient(amiibos: []))
@@ -33,8 +33,8 @@ struct AmiiboServiceMockTests {
#expect(amiibos.isEmpty) #expect(amiibos.isEmpty)
} }
@Test("returns amiibos when mock provides a list") @Test
func getAmiibosList() async throws { func `returns amiibos when mock provides a list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiibos: Fixtures.amiibos)) let service = AmiiboService(client: AmiiboMockClient(amiibos: Fixtures.amiibos))
@@ -47,8 +47,8 @@ struct AmiiboServiceMockTests {
#expect(amiibos.first?.imageURL != nil) #expect(amiibos.first?.imageURL != nil)
} }
@Test("throws notFound when mock provides no amiibos") @Test
func getAmiibosNotFound() async { func `throws notFound when mock provides no amiibos`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -59,8 +59,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for amiibos when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getAmiibosThrows(error: AmiiboServiceError) async { func `throws error for amiibos when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))
@@ -73,8 +73,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Amiibo Series tests // MARK: Get Amiibo Series tests
@Test("returns empty amiibo series when mock provides an empty list") @Test
func getAmiiboSeriesEmpty() async throws { func `returns empty amiibo series when mock provides an empty list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiiboSeries: [])) let service = AmiiboService(client: AmiiboMockClient(amiiboSeries: []))
@@ -85,8 +85,8 @@ struct AmiiboServiceMockTests {
#expect(amiiboSeries.isEmpty) #expect(amiiboSeries.isEmpty)
} }
@Test("returns amiibo series when mock provides a list") @Test
func getAmiiboSeriesList() async throws { func `returns amiibo series when mock provides a list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiiboSeries: Fixtures.amiiboSeries)) let service = AmiiboService(client: AmiiboMockClient(amiiboSeries: Fixtures.amiiboSeries))
@@ -97,8 +97,8 @@ struct AmiiboServiceMockTests {
#expect(amiiboSeries == Fixtures.amiiboSeries) #expect(amiiboSeries == Fixtures.amiiboSeries)
} }
@Test("throws notFound when mock provides no amiibo series") @Test
func getAmiiboSeriesNotFound() async { func `throws notFound when mock provides no amiibo series`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -109,8 +109,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for amiibo series when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getAmiiboSeriesThrows(error: AmiiboServiceError) async { func `throws error for amiibo series when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))
@@ -123,8 +123,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Amiibo Types tests // MARK: Get Amiibo Types tests
@Test("returns empty amiibo types when mock provides an empty list") @Test
func getAmiiboTypesEmpty() async throws { func `returns empty amiibo types when mock provides an empty list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiiboTypes: [])) let service = AmiiboService(client: AmiiboMockClient(amiiboTypes: []))
@@ -135,8 +135,8 @@ struct AmiiboServiceMockTests {
#expect(amiiboTypes.isEmpty) #expect(amiiboTypes.isEmpty)
} }
@Test("returns amiibo types when mock provides a list") @Test
func getAmiiboTypesList() async throws { func `returns amiibo types when mock provides a list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(amiiboTypes: Fixtures.amiiboTypes)) let service = AmiiboService(client: AmiiboMockClient(amiiboTypes: Fixtures.amiiboTypes))
@@ -147,8 +147,8 @@ struct AmiiboServiceMockTests {
#expect(amiiboTypes == Fixtures.amiiboTypes) #expect(amiiboTypes == Fixtures.amiiboTypes)
} }
@Test("throws notFound when mock provides no amiibo types") @Test
func getAmiiboTypesNotFound() async { func `throws notFound when mock provides no amiibo types`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -159,8 +159,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for amiibo types when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getAmiiboTypesThrows(error: AmiiboServiceError) async { func `throws error for amiibo types when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))
@@ -173,8 +173,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Game Characters tests // MARK: Get Game Characters tests
@Test("returns empty game characters when mock provides an empty list") @Test
func getGameCharactersEmpty() async throws { func `returns empty game characters when mock provides an empty list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(gameCharacters: [])) let service = AmiiboService(client: AmiiboMockClient(gameCharacters: []))
@@ -185,8 +185,8 @@ struct AmiiboServiceMockTests {
#expect(gameCharacters.isEmpty) #expect(gameCharacters.isEmpty)
} }
@Test("returns game characters when mock provides a list") @Test
func getGameCharactersList() async throws { func `returns game characters when mock provides a list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(gameCharacters: Fixtures.gameCharacters)) let service = AmiiboService(client: AmiiboMockClient(gameCharacters: Fixtures.gameCharacters))
@@ -197,8 +197,8 @@ struct AmiiboServiceMockTests {
#expect(gameCharacters == Fixtures.gameCharacters) #expect(gameCharacters == Fixtures.gameCharacters)
} }
@Test("throws notFound when mock provides no game characters") @Test
func getGameCharactersNotFound() async { func `throws notFound when mock provides no game characters`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -209,8 +209,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for game characters when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getGameCharactersThrows(error: AmiiboServiceError) async { func `throws error for game characters when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))
@@ -223,8 +223,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Game Series tests // MARK: Get Game Series tests
@Test("returns empty game series when mock provides an empty list") @Test
func getGameSeriesEmpty() async throws { func `returns empty game series when mock provides an empty list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(gameSeries: [])) let service = AmiiboService(client: AmiiboMockClient(gameSeries: []))
@@ -235,8 +235,8 @@ struct AmiiboServiceMockTests {
#expect(gameSeries.isEmpty) #expect(gameSeries.isEmpty)
} }
@Test("returns game series when mock provides a list") @Test
func getGameSeriesList() async throws { func `returns game series when mock provides a list`() async throws {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(gameSeries: Fixtures.gameSeries)) let service = AmiiboService(client: AmiiboMockClient(gameSeries: Fixtures.gameSeries))
@@ -247,8 +247,8 @@ struct AmiiboServiceMockTests {
#expect(gameSeries == Fixtures.gameSeries) #expect(gameSeries == Fixtures.gameSeries)
} }
@Test("throws notFound when mock provides no game series") @Test
func getGameSeriesNotFound() async { func `throws notFound when mock provides no game series`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -259,8 +259,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for game series when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getGameSeriesThrows(error: AmiiboServiceError) async { func `throws error for game series when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))
@@ -273,8 +273,8 @@ struct AmiiboServiceMockTests {
// MARK: Get Last Updated tests // MARK: Get Last Updated tests
@Test("returns date when mock provides a last updated date") @Test
func getLastUpdated() async throws { func `returns date when mock provides a last updated date`() async throws {
// GIVEN // GIVEN
let expectedDate = Date(timeIntervalSince1970: 1_700_000_000) let expectedDate = Date(timeIntervalSince1970: 1_700_000_000)
let service = AmiiboService(client: AmiiboMockClient(lastUpdated: expectedDate)) let service = AmiiboService(client: AmiiboMockClient(lastUpdated: expectedDate))
@@ -286,8 +286,8 @@ struct AmiiboServiceMockTests {
#expect(lastUpdated == expectedDate) #expect(lastUpdated == expectedDate)
} }
@Test("throws notFound when mock provides no last updated date") @Test
func getLastUpdatedNotFound() async { func `throws notFound when mock provides no last updated date`() async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient()) let service = AmiiboService(client: AmiiboMockClient())
@@ -298,8 +298,8 @@ struct AmiiboServiceMockTests {
} }
} }
@Test("throws error for last updated when mock is configured with error", arguments: Errors.all) @Test(arguments: Errors.all)
func getLastUpdatedThrows(error: AmiiboServiceError) async { func `throws error for last updated when mock is configured with error`(error: AmiiboServiceError) async {
// GIVEN // GIVEN
let service = AmiiboService(client: AmiiboMockClient(error: error)) let service = AmiiboService(client: AmiiboMockClient(error: error))