rock-n-code/amiibo-service
1
0
Fork 0
Code Issues Pull Requests Actions Releases 15 Activity

Improvements on the AmiiboService service type initialization #12

Merged
javier merged 6 commits from improvement/api-client into main 2025-09-12 00:13:59 +00:00
Conversation 0 Commits 6 Files Changed 7
+1341 -283
javier commented 2025-09-12 00:13:49 +00:00
Owner
Copy Link
Copy Source

This PR addresses the issue #10 as described in the Possible Solution section in that issue.

This PR addresses the issue #10 as described in the *Possible Solution* section in that issue.
javier added the Kind/Enhancement
Priority
High
 labels 2025-09-12 00:13:49 +00:00
javier self-assigned this 2025-09-12 00:13:49 +00:00
javier added 6 commits 2025-09-12 00:13:50 +00:00
Removed the AmiiboClient enumeration type from the library target. 03fa6ee89b
Renamed the APIClient protocol as AmiiboClient in the library target and also, make it a public protocol. 2f0fb0cd7f
Conformed the AmiiboLiveClient client type in the library target to the AmiiboClient protocol. 6f3249833a
Improved the initializer function for the AmiiboService service type in the library target to use a AmiiboLiveClient client type as a default value. e5a541206a
Implemented backwards support for the AmiiboServiceLiveTests test cases in the tests target. aeeb690e0f
Moved the AmiiboMockClient client type from the library target to the tests target. 2431813d7e
javier merged commit 3d923982b1 into main 2025-09-12 00:13:59 +00:00
javier deleted branch improvement/api-client 2025-09-12 00:13:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Priority
High
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Reference: rock-n-code/amiibo-service#12
Delete Branch "improvement/api-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?