rock-n-code/amiibo-service
1
0
Fork 0
Code Issues Pull Requests Actions Releases 15 Activity

Some suggested improvements #16

Merged
javier merged 6 commits from library/suggested-improvements into main 2025-10-02 01:51:17 +00:00
Conversation 0 Commits 6 Files Changed 124
+375 -500
javier commented 2025-10-02 01:51:06 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to make some overall improvements to the library:

  • Fixed code duplication from supporting multiple Swift version in the AmiiboLiveClient client;
  • Improved the error handling from the client's calls in the AmiiboLiveClient client;
  • Conformed to AmiiboLiveClient and the filter types to the Sendable protocol;
  • Added the "transport" argument to the initializer of the AmiiboLiveClient client;
  • Updated the DocC library documentation.
This PR contains the work done to make some overall improvements to the library: * Fixed code duplication from supporting multiple Swift version in the `AmiiboLiveClient` client; * Improved the error handling from the client's calls in the `AmiiboLiveClient` client; * Conformed to `AmiiboLiveClient` and the filter types to the `Sendable` protocol; * Added the "transport" argument to the initializer of the `AmiiboLiveClient` client; * Updated the `DocC` library documentation.
javier added the Kind/Enhancement
Priority
Medium
 labels 2025-10-02 01:51:06 +00:00
javier self-assigned this 2025-10-02 01:51:06 +00:00
javier added 6 commits 2025-10-02 01:51:07 +00:00
Fixed the code duplication from supporting different Swift versions in the AmiiboLiveClient client in the library target. 8d0f00ec36
Improved the error handling from the client calls for the AmiiboLiveClient client in the library target. 903220050c
Conformed the AmiiboLiveClient and the filter types in the library target to the Sendable protocol. 09dcc9987a
Improved the generic interface for the "map(_: )" helper function for the AmiiboLiveClient client in the library target. cca7c21eff
Added the "transport" argument to the init()" initializer for the AmiiboLiveClient client in the library target. 07cfa1e4e4
Regenerated the DocC library documentation for Github Pages. a0ede2a30a
javier merged commit c303e1f8f3 into main 2025-10-02 01:51:17 +00:00
javier deleted branch library/suggested-improvements 2025-10-02 01:51:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Priority
Medium
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Reference: rock-n-code/amiibo-service#16
Delete Branch "library/suggested-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?