rock-n-code/amiibo-service
1
0
Fork 0
Code Issues Pull Requests Actions Releases 15 Activity

Tests updates and other fixes #27

Merged
javier merged 8 commits from library/tests-update into main 2026-03-27 17:14:27 +00:00
Conversation 0 Commits 8 Files Changed 151
+259 -197
javier commented 2026-03-27 17:14:19 +00:00
Owner
Copy Link
Copy Source

This PR contains the work done to update the live test data to its latest version. Plus other improvements have been made:

  • conformed the AmiiboServiceError error to the LocalizableError protocol,
  • improved the ISODateTimeTranscoder transcoder to handle the decoding of both ISO dates and timestamps,
  • removed a force-unwrapped from the AmiiboLiveClient type.
This PR contains the work done to update the live test data to its latest version. Plus other improvements have been made: * conformed the `AmiiboServiceError` error to the `LocalizableError` protocol, * improved the `ISODateTimeTranscoder` transcoder to handle the decoding of both ISO dates and timestamps, * removed a force-unwrapped from the `AmiiboLiveClient` type.
javier added the Kind/Enhancement
Priority
High
 labels 2026-03-27 17:14:19 +00:00
javier self-assigned this 2026-03-27 17:14:19 +00:00
javier added 8 commits 2026-03-27 17:14:20 +00:00
Updated some expectations for some of the cases on the AmiiboServiceLiveTests tests in the tests target. def42b576a
Conformed the AmiiboServiceError error in the library target to the LocalizedError protocol. 4128baa688
Regenerated the library documentation for both Xcode and Github Pages in the package. 255350ba3a
Addressed a ISO date+time decoding issue inside the "decode(_:)" method for the ISOTimestampTranscoder transcoder in the library target. a4b1c0e27f
Removed the force-unwrapped inside the "init(transport:)" initializer for the AmiiboLiveClient client in the library target. 156d1a5808
Added the "isoDate" static property for the DateFormatter+Properties extension in the library target. f1d649da16
Improved the ISODateTimeTranscoder transcoder in the library target to support both ISO dates and timestamps. 686895d057
Regenerated the library documentation for both Xcode and Github Pages in the package. 8310809f2d
javier merged commit 1488aa151e into main 2026-03-27 17:14:27 +00:00
javier deleted branch library/tests-update 2026-03-27 17:14:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Priority
High
Milestone
No items
No Milestone
Assignees
Clear assignees
javier (Javier Cicchelli)
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Reference: rock-n-code/amiibo-service#27
Delete Branch "library/tests-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?