rock-n-code/amiibo-service
1
0
Fork 0
Code Issues 1 Pull Requests Releases 8 Wiki Activity

[Feature] Service #4

Merged
javier merged 13 commits from feature/service into main 2023-04-21 18:16:38 +00:00
Conversation 0 Commits 13 Files Changed 26 +1001 -69
javier commented 2023-04-21 18:16:28 +00:00
Owner
Copy Link

This PR contains the work done to implement the actual public service interface to the Amiibo API.

To provide further details about this work:

  • defined a Filter protocol;
  • implemented the AmiiboFilter and the KeyNameFilter filters;
  • implemented the Result model;
  • defined the Service protocol;
  • implemented the AmiiboService concrete service;
  • fixed the path of the GetAmiiboEndpoint endpoint;
  • made the usage property of the Game model optional;
  • replaced the showGames and the showUsage flags of the AmiiboFilter filter with an enumeration.
This PR contains the work done to implement the actual public service interface to the Amiibo API. To provide further details about this work: - [x] defined a `Filter` protocol; - [x] implemented the `AmiiboFilter` and the `KeyNameFilter` filters; - [x] implemented the `Result` model; - [x] defined the `Service` protocol; - [x] implemented the `AmiiboService` concrete service; - [x] fixed the `path` of the `GetAmiiboEndpoint` endpoint; - [x] made the `usage` property of the `Game` model optional; - [x] replaced the `showGames` and the `showUsage` flags of the `AmiiboFilter` filter with an enumeration.
javier self-assigned this 2023-04-21 18:16:28 +00:00
javier added 13 commits 2023-04-21 18:16:29 +00:00
javier merged commit f34ce5289d into main 2023-04-21 18:16:38 +00:00
javier deleted branch feature/service 2023-04-21 18:16:38 +00:00
javier referenced this issue from a commit 2023-04-21 18:16:39 +00:00
[Feature] Service (#4)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees javier
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock-n-code/amiibo-service#4
No description provided.
Delete Branch "feature/service"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?